|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce: I've implemented a 'onReferenceFragmentUpdated' handler and checked the transitionType and transitionQualifiers. I've tested in FF50 & FF51. It's reproducable using the *Example* code from: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webNavigation/onReferenceFragmentUpdated Actual results: transitionType and transitionQualifiers were 'undefined' Expected results: They should have been implemented as the documentation says they're available since FF48
Component: Activity Streams: General → WebExtensions: Untriaged
Product: Firefox → Toolkit
luca writing up request for more details.
Assignee: nobody → lgreco
(In reply to :shell escalante from comment #1) > luca writing up request for more details. I looked into this and onReferenceFragmentUpdated event the transition properties are currently missing (and they shouldn't, especially given that the properties are populated for the similar onHistoryStateUpdated event). I'm going to attach a patch which adds the transition properties to the onReferenceFragmentUpdated events (and adds additional test cases to ensure that these properties are available on both onReferenceFragmentUpdated and onHistoryStateUpdated).
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
The attached patch pushed to try: - https://treeherder.mozilla.org/#/jobs?repo=try&revision=0855f88c793b7d9414ab8c9c9fa1d79ed2fe11a3
Comment on attachment 8831095 [details] Bug 1332995 - Add transition properties on onReferenceFragmentUpdated events Hi Shane and Andrew, can you take a look at this fix (pretty small) and the new test cases (a bit longer but not too much)?
Comment on attachment 8831095 [details] Bug 1332995 - Add transition properties on onReferenceFragmentUpdated events And a bonus test for onHistoryStateUpdated :)
Attachment #8831095 - Flags: feedback?(mixedpuppy) → feedback+
Comment on attachment 8831095 [details] Bug 1332995 - Add transition properties on onReferenceFragmentUpdated events https://reviewboard.mozilla.org/r/107740/#review109324
Attachment #8831095 - Flags: review?(aswan) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ae91b2b5bb69 Add transition properties on onReferenceFragmentUpdated events r=aswan
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.