1333064 - Unblocked malware downloads are styled incorrectly in the Downloads Panel

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[:Paolo Amadini]

When a downloaded file marked as malware is unblocked, the red background is still shown in the Downloads Panel.

This bug fundamentally existed before bug 950058 was implemented, but the latter made it visible because the new styling just checks the "verdict" attribute to show the background color without checking other attributes.

At the time, to keep things simple we implemented an API where "succeeded" and "error" can be true at the same time, but it turns out it may have been worth spending a bit more time to design a better solution.

Comment 1

[:Paolo Amadini]

Attachment: Bug 1333064 - Unblocked malware downloads are styled incorrectly in the Downloads Panel.

Review commit: https://reviewboard.mozilla.org/r/106544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106544/

Comment 2

[:Paolo Amadini]

This can be tested manually at <https://testsafebrowsing.appspot.com/>.

Comment 3

[:Paolo Amadini]

[Tracking Requested - why for this release]:
This slipped through when I reviewed bug 950058, which is targeted at Firefox 52.

It's a rare case because malware downloads are a very small percentage, and the ones that are unblocked should be even smaller, but it should still be fixed for correctness.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8829433 [details]
Bug 1333064 - Unblocked malware downloads are styled incorrectly in the Downloads Panel.

https://reviewboard.mozilla.org/r/106544/#review108302

the code makes sense, and it works (tested locally)!

Comment 5

[:Paolo Amadini]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31f2b6fc8524
Unblocked malware downloads are styled incorrectly in the Downloads Panel. r=mak

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/31f2b6fc8524

Comment 8

[Julien Cristau [:jcristau]]

Tracking for 52 as caused by a recent change there.

Comment 9

[:Paolo Amadini]

Comment on attachment 8829433 [details]
Bug 1333064 - Unblocked malware downloads are styled incorrectly in the Downloads Panel.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 950058
[User impact if declined]: Incorrect styling after unblocking a download
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Yes, see comment 0.
[List of other uplifts needed for the feature/fix]: Bug 991965
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: This is a simple change that only influences a CSS attribute used for styling, after a blocked download has been unblocked.
[String changes made/needed]: None

Comment 10

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this bug using Fx 54.0a1, build ID: 20170123080351, on Windows 10 x64.
I can confirm this issue is fixed, after allowing a malware download the color changes back,  I verified using Fx 54.0a1, build ID:20170130030205 on Windows 10 x64, Mac OS X 10.11 and Ubuntu 14.04 LTS.

Cheers!

Comment 11

[:Paolo Amadini]

I think the tracking flag from comment 8 was reset accidentally.

Comment 12

[Julien Cristau [:jcristau]]

(In reply to :Paolo Amadini from comment #11)
> I think the tracking flag from comment 8 was reset accidentally.

Yes, confirmed with Cristian on IRC this was an accident; resetting the flag, and tracking for 53 while I'm at it.

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 8829433 [details]
Bug 1333064 - Unblocked malware downloads are styled incorrectly in the Downloads Panel.

download panel styling fix, for aurora53 and beta52, should be in 52.0b3.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0055af50eaef

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c3e3b17bcc69

Comment 16

[Bogdan Maris, Desktop Test Engineering]

I've reproduced the initial issue described in comment 0 using old Nightly from 2017-01-23 and verified that the issues is not reproducible anymore using Firefox 52 beta 8 and latest Developer Edition 53.0a2 across platforms (macOS 10.12.3, Ubuntu 16.04 32it, Windows 10 64bit).