Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Unblocked malware downloads are styled incorrectly in the Downloads Panel

VERIFIED FIXED in Firefox 52

Status

()

Firefox
Downloads Panel
VERIFIED FIXED
6 months ago
5 months ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

52 Branch
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox51 unaffected, firefox52+ verified, firefox53+ verified, firefox54 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
When a downloaded file marked as malware is unblocked, the red background is still shown in the Downloads Panel.

This bug fundamentally existed before bug 950058 was implemented, but the latter made it visible because the new styling just checks the "verdict" attribute to show the background color without checking other attributes.

At the time, to keep things simple we implemented an API where "succeeded" and "error" can be true at the same time, but it turns out it may have been worth spending a bit more time to design a better solution.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

6 months ago
This can be tested manually at <https://testsafebrowsing.appspot.com/>.
(Assignee)

Comment 3

6 months ago
[Tracking Requested - why for this release]:
This slipped through when I reviewed bug 950058, which is targeted at Firefox 52.

It's a rare case because malware downloads are a very small percentage, and the ones that are unblocked should be even smaller, but it should still be fixed for correctness.
tracking-firefox52: --- → ?

Comment 4

6 months ago
mozreview-review
Comment on attachment 8829433 [details]
Bug 1333064 - Unblocked malware downloads are styled incorrectly in the Downloads Panel.

https://reviewboard.mozilla.org/r/106544/#review108302

the code makes sense, and it works (tested locally)!
Attachment #8829433 - Flags: review?(mak77) → review+
(Assignee)

Comment 5

6 months ago
Thanks!

Comment 6

6 months ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31f2b6fc8524
Unblocked malware downloads are styled incorrectly in the Downloads Panel. r=mak

Comment 7

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/31f2b6fc8524
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Assignee: nobody → paolo.mozmail
status-firefox51: --- → unaffected
status-firefox52: --- → affected
status-firefox53: --- → affected
tracking-firefox53: --- → ?
Version: unspecified → 52 Branch
Tracking for 52 as caused by a recent change there.
tracking-firefox52: ? → +
(Assignee)

Comment 9

6 months ago
Comment on attachment 8829433 [details]
Bug 1333064 - Unblocked malware downloads are styled incorrectly in the Downloads Panel.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 950058
[User impact if declined]: Incorrect styling after unblocking a download
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Yes, see comment 0.
[List of other uplifts needed for the feature/fix]: Bug 991965
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: This is a simple change that only influences a CSS attribute used for styling, after a blocked download has been unblocked.
[String changes made/needed]: None
Attachment #8829433 - Flags: approval-mozilla-beta?
Attachment #8829433 - Flags: approval-mozilla-aurora?
I reproduced this bug using Fx 54.0a1, build ID: 20170123080351, on Windows 10 x64.
I can confirm this issue is fixed, after allowing a malware download the color changes back,  I verified using Fx 54.0a1, build ID:20170130030205 on Windows 10 x64, Mac OS X 10.11 and Ubuntu 14.04 LTS.

Cheers!
status-firefox54: fixed → verified
tracking-firefox52: + → ?
(Assignee)

Comment 11

6 months ago
I think the tracking flag from comment 8 was reset accidentally.
Flags: needinfo?(jcristau)
(In reply to :Paolo Amadini from comment #11)
> I think the tracking flag from comment 8 was reset accidentally.

Yes, confirmed with Cristian on IRC this was an accident; resetting the flag, and tracking for 53 while I'm at it.
tracking-firefox52: ? → +
tracking-firefox53: ? → +
Flags: needinfo?(jcristau)
Comment on attachment 8829433 [details]
Bug 1333064 - Unblocked malware downloads are styled incorrectly in the Downloads Panel.

download panel styling fix, for aurora53 and beta52, should be in 52.0b3.
Attachment #8829433 - Flags: approval-mozilla-beta?
Attachment #8829433 - Flags: approval-mozilla-beta+
Attachment #8829433 - Flags: approval-mozilla-aurora?
Attachment #8829433 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/0055af50eaef
status-firefox53: affected → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/c3e3b17bcc69
status-firefox52: affected → fixed
Flags: qe-verify+
I've reproduced the initial issue described in comment 0 using old Nightly from 2017-01-23 and verified that the issues is not reproducible anymore using Firefox 52 beta 8 and latest Developer Edition 53.0a2 across platforms (macOS 10.12.3, Ubuntu 16.04 32it, Windows 10 64bit).
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
status-firefox53: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.