[FIX]webBrowserPrint->Print shouldn't assert on failure

RESOLVED INVALID

Status

()

Core
Printing: Output
P1
normal
RESOLVED INVALID
16 years ago
11 years ago

People

(Reporter: timeless, Assigned: rods (gone))

Tracking

({assertion})

Trunk
Future
x86
FreeBSD
assertion
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
steps:
file>new message
file>print
cancel

WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(webBrowserPrint->Print(0, (nsIWebProgressListener*)0))) failed, file /home/timeless/mozilla/editor/composer/src/nsEditorShell.cpp, line 1721

#PRINT ERROR: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIEditorShell.Print]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://messenger/content/messengercompose/MsgComposeCommands.js :: DoCommandPrint :: line 1074"  data: no]

expect: no assertion that print succeeded, since failing is perfectly valid.
no js error (from mail) when print fails, for the same reason.

Comment 1

16 years ago
is this a DUP of 131174 ?
(Reporter)

Comment 2

16 years ago
no, why would it be?
Keywords: assertion
(Assignee)

Comment 3

16 years ago
Created attachment 77219 [details] [diff] [review]
patch

Simple low risk patch, ther eis a try block around the JS that calls this
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: webBrowserPrint->Print shouldn't assert on failure → [FIX]webBrowserPrint->Print shouldn't assert on failure
Target Milestone: --- → Future
(Reporter)

Updated

16 years ago
Attachment #77219 - Flags: review+
(Reporter)

Updated

13 years ago
Attachment #77219 - Flags: superreview?(bzbarsky)
Comment on attachment 77219 [details] [diff] [review]
patch

sr=bzbarsky
Attachment #77219 - Flags: superreview?(bzbarsky) → superreview+

Comment 5

11 years ago
I think someone forgot to close this, so I'm closing it.  The patch is in a file that doesn't even exist anymore.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.