Closed
Bug 133307
Opened 22 years ago
Closed 18 years ago
[FIX]webBrowserPrint->Print shouldn't assert on failure
Categories
(Core :: Printing: Output, defect, P1)
Tracking
()
RESOLVED
INVALID
Future
People
(Reporter: timeless, Assigned: rods)
Details
(Keywords: assertion)
Attachments
(1 file)
|
690 bytes,
patch
|
timeless
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
steps: file>new message file>print cancel WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(webBrowserPrint->Print(0, (nsIWebProgressListener*)0))) failed, file /home/timeless/mozilla/editor/composer/src/nsEditorShell.cpp, line 1721 #PRINT ERROR: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIEditorShell.Print]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://messenger/content/messengercompose/MsgComposeCommands.js :: DoCommandPrint :: line 1074" data: no] expect: no assertion that print succeeded, since failing is perfectly valid. no js error (from mail) when print fails, for the same reason.
|
Assignee | |
Comment 3•22 years ago
|
||
Simple low risk patch, ther eis a try block around the JS that calls this
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: webBrowserPrint->Print shouldn't assert on failure → [FIX]webBrowserPrint->Print shouldn't assert on failure
Target Milestone: --- → Future
Attachment #77219 -
Flags: review+
Attachment #77219 -
Flags: superreview?(bzbarsky)
|
||
Comment 4•20 years ago
|
||
Comment on attachment 77219 [details] [diff] [review] patch sr=bzbarsky
Attachment #77219 -
Flags: superreview?(bzbarsky) → superreview+
|
||
Comment 5•18 years ago
|
||
I think someone forgot to close this, so I'm closing it. The patch is in a file that doesn't even exist anymore.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•