Closed
Bug 1333089
Opened 7 years ago
Closed 7 years ago
RTL - The back arrow is pointing left instead of right on Android
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox52 unaffected, firefox53 verified, firefox54 verified)
VERIFIED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox53 | --- | verified |
firefox54 | --- | verified |
People
(Reporter: sflorean, Assigned: maliu)
References
Details
(Keywords: regression)
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
Environment: Device: LG G4 (Android 5.1); Build: (AR) Nightly 53.0a1 (2017-01-23); Steps to reproduce: 1. Launch Fennec; 2. Go to Settings; 3. Observe the back arrow. Expected result: The back arrow is pointing right. Actual result: The back arrow is pointing left. Notes: Follow up from: https://bugzilla.mozilla.org/show_bug.cgi?id=1323763#c20
Updated•7 years ago
|
Flags: needinfo?(max)
Keywords: regression
Assignee | ||
Comment 1•7 years ago
|
||
Affirmative, I found this symptom only exist on L and this is my first priority to fix. I'll take it from here. Hope the patch won't be too complicated to up-lift.
Assignee: nobody → max
Flags: needinfo?(max)
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8832736 [details] Bug 1333089 - Force update up indicator drawable in onCreate even locale did not change, https://reviewboard.mozilla.org/r/108942/#review110248 ::: mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java:237 (Diff revision 1) > setTitle(newTitle); > } > } > > + private void updateHomeAsUpIndicator() { > + ActionBar actionBar = getSupportActionBar(); nit: final ::: mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java:336 (Diff revision 1) > finishChoosingTransition(); > } > > private void checkLocale() { > + // Force update navigate up icon by current layout direction > + updateHomeAsUpIndicator(); Is this only needed on L? If so we could wrap it in an SDK check and then have the opportunity to remove it in the future.
Attachment #8832736 -
Flags: review?(s.kaspari) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d77cc2c1ef81 Force update up indicator drawable in onCreate even locale did not change, r=sebastian
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d77cc2c1ef81
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 7•7 years ago
|
||
Sounds like we need at least an Aurora approval here. Is Beta also affected?
status-firefox52:
--- → ?
Flags: needinfo?(max)
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8832736 [details] Bug 1333089 - Force update up indicator drawable in onCreate even locale did not change, Approval Request Comment [Feature/Bug causing the regression]:RTL support [User impact if declined]:Navigate back button mirrored on Settings page on RTL system language. [Is this code covered by automated tests?]:No [Has the fix been verified in Nightly?]:Yes [Needs manual test from QE? If yes, steps to reproduce]: Yes. On Android 5.0/5.1, set system language to RTL(he/ar). Go to Settings page of Fennec, navigate back button on ActionBar should point to the right. [List of other uplifts needed for the feature/fix]: N/A [Is the change risky?]:No [Why is the change risky/not risky?]: Only update the icon from other call flow and also safe to touch view on main thread. [String changes made/needed]:No
Flags: needinfo?(max)
Attachment #8832736 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 9•7 years ago
|
||
Hi Ryan, Beta is not affected. RTL support begin from 53.
Updated•7 years ago
|
Comment 10•7 years ago
|
||
Hello Brindusa, could you help find someone to verify if this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(brindusa.tot)
Comment 11•7 years ago
|
||
Hey Gerry - Brindusa is working on Desktop. Sorina (from mobile team) as reporter will be OK to verify it.
Flags: needinfo?(brindusa.tot) → needinfo?(sorina.florean)
Comment 12•7 years ago
|
||
Used my wrong mail to comment. Sorry
Comment 13•7 years ago
|
||
Comment on attachment 8832736 [details] Bug 1333089 - Force update up indicator drawable in onCreate even locale did not change, Let's take this in aurora, still good to verify it but I think we can take the chance.
Attachment #8832736 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 14•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/54bc0a945089
Reporter | ||
Comment 15•7 years ago
|
||
Verified as fixed in AR build 54.0a1 (2017-02-07); Device: LG G4 (Android 5.1); The back arrow is pointing right.
Flags: needinfo?(sorina.florean)
Reporter | ||
Comment 16•7 years ago
|
||
Verified as fixed in AR build 53.0a2 (2017-02-08); Device: LG G4 (Android 5.1).
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•