Closed Bug 1333089 Opened 7 years ago Closed 7 years ago

RTL - The back arrow is pointing left instead of right on Android

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

53 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox52 unaffected, firefox53 verified, firefox54 verified)

VERIFIED FIXED
Firefox 54
Tracking Status
firefox52 --- unaffected
firefox53 --- verified
firefox54 --- verified

People

(Reporter: sflorean, Assigned: maliu)

References

Details

(Keywords: regression)

Attachments

(1 file)

Environment: 
Device: LG G4 (Android 5.1);
Build: (AR) Nightly 53.0a1 (2017-01-23);

Steps to reproduce:
1. Launch Fennec; 
2. Go to Settings;
3. Observe the back arrow.

Expected result:
The back arrow is pointing right.

Actual result:
The back arrow is pointing left.

Notes:
Follow up from: https://bugzilla.mozilla.org/show_bug.cgi?id=1323763#c20
Flags: needinfo?(max)
Keywords: regression
Affirmative, I found this symptom only exist on L and this is my first priority to fix. I'll take it from here. Hope the patch won't be too complicated to up-lift.
Assignee: nobody → max
Flags: needinfo?(max)
Comment on attachment 8832736 [details]
Bug 1333089 - Force update up indicator drawable in onCreate even locale did not change,

https://reviewboard.mozilla.org/r/108942/#review110248

::: mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java:237
(Diff revision 1)
>              setTitle(newTitle);
>          }
>      }
>  
> +    private void updateHomeAsUpIndicator() {
> +        ActionBar actionBar = getSupportActionBar();

nit: final

::: mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java:336
(Diff revision 1)
>          finishChoosingTransition();
>      }
>  
>      private void checkLocale() {
> +        //  Force update navigate up icon by current layout direction
> +        updateHomeAsUpIndicator();

Is this only needed on L? If so we could wrap it in an SDK check and then have the opportunity to remove it in the future.
Attachment #8832736 - Flags: review?(s.kaspari) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d77cc2c1ef81
Force update up indicator drawable in onCreate even locale did not change, r=sebastian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d77cc2c1ef81
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Sounds like we need at least an Aurora approval here. Is Beta also affected?
Flags: needinfo?(max)
Comment on attachment 8832736 [details]
Bug 1333089 - Force update up indicator drawable in onCreate even locale did not change,

Approval Request Comment
[Feature/Bug causing the regression]:RTL support
[User impact if declined]:Navigate back button mirrored on Settings page on RTL system language.
[Is this code covered by automated tests?]:No
[Has the fix been verified in Nightly?]:Yes
[Needs manual test from QE? If yes, steps to reproduce]: Yes. On Android 5.0/5.1, set system language to RTL(he/ar). Go to Settings page of Fennec, navigate back button on ActionBar should point to the right.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]:No
[Why is the change risky/not risky?]: Only update the icon from other call flow and also safe to touch view on main thread.
[String changes made/needed]:No
Flags: needinfo?(max)
Attachment #8832736 - Flags: approval-mozilla-aurora?
Hi Ryan,

Beta is not affected. RTL support begin from 53.
Hello Brindusa, could you help find someone to verify if this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(brindusa.tot)
Hey Gerry - Brindusa is working on Desktop. 
Sorina (from mobile team) as reporter will be OK to verify it.
Flags: needinfo?(brindusa.tot) → needinfo?(sorina.florean)
Used my wrong mail to comment. Sorry
Comment on attachment 8832736 [details]
Bug 1333089 - Force update up indicator drawable in onCreate even locale did not change,

Let's take this in aurora, still good to verify it but I think we can take the chance.
Attachment #8832736 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed in AR build 54.0a1 (2017-02-07);
Device: LG G4 (Android 5.1); The back arrow is pointing right.
Flags: needinfo?(sorina.florean)
Verified as fixed in AR build 53.0a2 (2017-02-08);
Device: LG G4 (Android 5.1).
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.