Closed Bug 1333164 Opened 8 years ago Closed 8 years ago

100 instances of "Couldn't convert chrome URL: chrome://mochitests/tests/SimpleTest/test.css" emitted from none during linux64 debug testing

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: erahm, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1333164 - fix invalid references to mochitest stylesheet,
59 bytes, text/x-review-board-request
erahm
: review+
Details
> 82 Couldn't convert chrome URL: chrome://mochitests/tests/SimpleTest/test.css This warning [1] shows up in the following test suites: > 34 - test-linux64/debug-mochitest-chrome-3 c3 > 30 - test-linux64/debug-mochitest-chrome-2 c2 > 14 - test-linux64/debug-mochitest-chrome-1 c1 > 2 - test-linux64/debug-mochitest-clipboard-e10s cl > 2 - test-linux64/debug-mochitest-clipboard cl It shows up in 35 tests. A few of the most prevalent: > 4 - toolkit/content/tests/widgets/test_videocontrols_onclickplay.html > 4 - layout/mathml/tests/test_disabled_chrome.html > 4 - layout/generic/test/test_selection_underline.html > 4 - layout/svg/tests/test_disabled_chrome.html > 4 - dom/base/test/chrome/test_bug383430.html > 4 - dom/base/test/chrome/test_bug380418.html > 2 - widget/tests/test_bug760802.xul > 2 - toolkit/content/tests/widgets/test_popupanchor.xul > 2 - docshell/test/chrome/test_bug453650.xul > 2 - layout/xul/test/test_bug467442.xul [1] https://hg.mozilla.org/mozilla-central/annotate/5a4412474c63/none#l0
Blocks: 1330123
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa931d9ffc6d
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8829855 [details] Bug 1333164 - fix invalid references to mochitest stylesheet, https://reviewboard.mozilla.org/r/106840/#review107974 This looks good, r=me but maybe wait to land. I'm backfilling the m-c1,c2,c3,cl e10s-m-cl tests on your try push to verify it fixes all the missing `SimpleTest/test.css` references.
Attachment #8829855 - Flags: review?(erahm) → review+
There are still 24 instances of this warning in the try push: > 24 Couldn't convert chrome URL: chrome://mochitests/tests/SimpleTest/test.css This warning shows up in the following test suites: > 16 - test-linux64/debug-mochitest-chrome-3 c3 > 8 - test-linux64/debug-mochitest-chrome-1 c1 It shows up in 6 tests. A few of the most prevalent: > 4 - toolkit/content/tests/widgets/test_videocontrols_onclickplay.html > 4 - layout/mathml/tests/test_disabled_chrome.html > 4 - dom/base/test/chrome/test_bug380418.html > 4 - layout/generic/test/test_selection_underline.html > 4 - layout/svg/tests/test_disabled_chrome.html > 4 - dom/base/test/chrome/test_bug383430.html
Additionally I'm seeing a very similar warning that we might want to fix in this bug as well (or I can file a follow up). Note that they're using 'contents' instead of 'content': > 44 Couldn't convert chrome URL: chrome://mochikit/contents/tests/SimpleTest/test.css This warning shows up in the following test suites: > 44 - test-linux64/debug-mochitest-chrome-3 c3 It shows up in 11 tests. A few of the most prevalent: > 4 - toolkit/components/extensions/test/mochitest/test_chrome_ext_webnavigation_resolved_urls.html > 4 - toolkit/components/extensions/test/mochitest/test_chrome_ext_hybrid_addons.html > 4 - toolkit/components/extensions/test/mochitest/test_chrome_ext_idle.html > 4 - toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_saveAs.html > 4 - toolkit/components/extensions/test/mochitest/test_chrome_ext_eventpage_warning.html > 4 - toolkit/components/extensions/test/mochitest/test_chrome_ext_background_debug_global.html > 4 - toolkit/components/extensions/test/mochitest/test_chrome_ext_identity.html > 4 - toolkit/components/extensions/test/mochitest/test_chrome_ext_trustworthy_origin.html > 4 - toolkit/components/extensions/test/mochitest/test_chrome_ext_contentscript_unrecognizedprop_warning.html > 4 - toolkit/components/extensions/test/mochitest/test_chrome_ext_background_page.html > 4 - toolkit/components/extensions/test/mochitest/test_chrome_native_messaging_paths.html
Comment on attachment 8829855 [details] Bug 1333164 - fix invalid references to mochitest stylesheet, I can't seem to change my r+ in review board, but let f+ this for now.
Attachment #8829855 - Flags: review+ → feedback+
(In reply to Eric Rahm [:erahm] from comment #7) > Comment on attachment 8829855 [details] > Bug 1333164 - fix invalid references to mochitest stylesheet, > > I can't seem to change my r+ in review board, but let f+ this for now. Click finish review again, select something other than r+ in the dropdown, should work I think? Anyway, I'll try fixing this up 'soon' to include the HTML files, hopefully tomorrow.
Attachment #8829855 - Flags: review?(erahm)
Comment on attachment 8829855 [details] Bug 1333164 - fix invalid references to mochitest stylesheet, https://reviewboard.mozilla.org/r/106840/#review108462 Thanks for updating! Changes look good and try run shows the warnings are gone.
Attachment #8829855 - Flags: review?(erahm) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/39cce2d50c54 fix invalid references to mochitest stylesheet, r=erahm
https://hg.mozilla.org/mozilla-central/rev/39cce2d50c54
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: