1,100 instances of "NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012" emitted from netwerk/base/nsIOService.cpp during linux64 debug testing

RESOLVED FIXED in Firefox 54

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: erahm, Assigned: valentin.gosu)

Tracking

(Blocks 1 bug)

Trunk
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

> 1069 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file netwerk/base/nsIOService.cpp, line 793

This warning [1] shows up in the following test suites:

>     92 - test-linux64/debug-mochitest-chrome-3 c3
>     66 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>     58 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>     56 - test-linux64/debug-mochitest-browser-chrome-8 bc8
>     56 - test-linux64/debug-mochitest-browser-chrome-9 bc9
>     51 - test-linux64/debug-mochitest-chrome-2 c2
>     36 - test-linux64/debug-mochitest-chrome-1 c1
>     32 - test-linux64/debug-mochitest-clipboard cl
>     30 - test-linux64/debug-mochitest-clipboard-e10s cl
>     17 - test-linux64/debug-mochitest-5 5
>     17 - test-linux64/debug-mochitest-e10s-5 5
>     15 - test-linux64/debug-mochitest-browser-chrome-7 bc7
>     14 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>     14 - test-linux64/debug-mochitest-browser-chrome-4 bc4
>     14 - test-linux64/debug-mochitest-browser-chrome-5 bc5
>     14 - test-linux64/debug-mochitest-3 3
>     14 - test-linux64/debug-mochitest-e10s-10 10
>     14 - test-linux64/debug-mochitest-10 10
>     14 - test-linux64/debug-mochitest-e10s-9 9
>     14 - test-linux64/debug-mochitest-browser-chrome-6 bc6
>     14 - test-linux64/debug-mochitest-8 8
>     14 - test-linux64/debug-mochitest-9 9
>     14 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>     14 - test-linux64/debug-mochitest-browser-chrome-3 bc3
>     14 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>     13 - test-linux64/debug-mochitest-e10s-8 8
>     13 - test-linux64/debug-mochitest-e10s-6 6
>     13 - test-linux64/debug-mochitest-e10s-1 1
>     13 - test-linux64/debug-mochitest-e10s-4 4
>     13 - test-linux64/debug-mochitest-browser-chrome-2 bc2
>     13 - test-linux64/debug-mochitest-4 4
>     13 - test-linux64/debug-mochitest-e10s-7 7
>     13 - test-linux64/debug-mochitest-e10s-2 2
>     13 - test-linux64/debug-mochitest-2 2
>     13 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>     13 - test-linux64/debug-mochitest-e10s-3 3
>     13 - test-linux64/debug-mochitest-7 7
>     13 - test-linux64/debug-mochitest-1 1
>     13 - test-linux64/debug-mochitest-browser-chrome-1 bc1
>     13 - test-linux64/debug-mochitest-6 6
>     13 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>     13 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>      9 - test-linux64/debug-mochitest-media mda
>      9 - test-linux64/debug-mochitest-media-e10s mda
>      7 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>      7 - test-linux64/debug-mochitest-devtools-chrome-5 dt5
>      7 - test-linux64/debug-mochitest-gpu-e10s gpu
>      6 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
>      6 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
>      6 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
>      6 - test-linux64/debug-mochitest-devtools-chrome-8 dt8
>      6 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>      5 - test-linux64/debug-mochitest-jetpack JP
>      5 - test-linux64/debug-mochitest-devtools-chrome-7 dt7
>      4 - test-linux64/debug-mochitest-devtools-chrome-6 dt6
>      4 - test-linux64/debug-mochitest-devtools-chrome-9 dt9
>      4 - test-linux64/debug-mochitest-webgl-e10s-3 gl3
>      4 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
>      4 - test-linux64/debug-mochitest-webgl-3 gl3
>      4 - test-linux64/debug-mochitest-devtools-chrome-1 dt1
>      3 - test-linux64/debug-crashtest C
>      3 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
>      3 - test-linux64/debug-mochitest-devtools-chrome-2 dt2
>      2 - test-linux64/debug-mochitest-devtools-chrome-3 dt3
>      2 - test-linux64/debug-mochitest-webgl-1 gl1
>      2 - test-linux64/debug-mochitest-a11y a11y
>      2 - test-linux64/debug-mochitest-devtools-chrome-4 dt4
>      2 - test-linux64/debug-mochitest-webgl-e10s-1 gl1
>      2 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
>      2 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
>      1 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
>      1 - test-linux64/debug-gtest GTest
>      1 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
>      1 - Static Checking Build S
>      1 - test-linux64/debug-mochitest-browser-chrome-10 bc10
>      1 - build-linux64/debug B
>      1 - test-linux64/debug-mochitest-devtools-chrome-10 dt10
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
>      1 - test-linux64/debug-mochitest-webgl-e10s-2 gl2
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>      1 - test-linux64/debug-mochitest-browser-chrome-11 bc11
>      1 - test-linux64/debug-mochitest-browser-chrome-12 bc12
>      1 - test-linux64/debug-mochitest-webgl-2 gl2

It shows up in 139 tests. A few of the most prevalent:

>    381 -        Shutdown
>    290 - [e10s] Shutdown
>     55 - [e10s] toolkit/mozapps/extensions/test/browser/test-window/browser_details.js
>     55 -        toolkit/mozapps/extensions/test/browser/browser_details.js
>     55 -        toolkit/mozapps/extensions/test/browser/test-window/browser_details.js
>     55 - [e10s] toolkit/mozapps/extensions/test/browser/browser_details.js
>     16 -        layout/style/test/chrome/test_bug418986-2.xul
>      3 -        jetpack-package/addon-sdk/source/test/test-simple-prefs.js.testUnloadOfDynamicPrefGeneration
>      2 -        toolkit/components/extensions/test/mochitest/test_chrome_ext_webnavigation_resolved_urls.html
>      2 -        dom/html/test/test_audio_wakelock.html

[1] https://hg.mozilla.org/mozilla-central/annotate/5a4412474c63/netwerk/base/nsIOService.cpp#l793
This correlates pretty much completely with bug 1333172. The flow looks about right:

> - |nsIOService::NewChannelFromURIWithProxyFlagsInternal| calls |NewChannel|
>   - |NewChannel| calls |NS_NewChannelInternal|
>     - |NS_NewChannelInternal| emits a warning when |NewChannelFromURI2| fails, returns that failure
>   - |NewChannel| returns the failure
> - |nsIOService::NewChannelFromURIWithProxyFlagsInternal| emits a warning on failure of |NewChannel| and returns

So a couple of things here:
  - I don't think these warnings are particularly useful, they're not telling us what they failed to load
  - They seem to correlate with "Couldn't convert chrome URL" messages (bug 1333162, bug 1333163, bug 1333164) which makes sense as we fallback to |NewChannel| in |nsIOService::NewChannelFromURIWithProxyFlagsInternal| if |NewChannel2| fails [1] and the chrome URL messages come from |nsChromeProtocolHandler::NewChannel2| [2]

[1] http://searchfox.org/mozilla-central/rev/30fcf167af036aeddf322de44a2fadd370acfd2f/netwerk/base/nsIOService.cpp#788-798
[2] http://searchfox.org/mozilla-central/rev/30fcf167af036aeddf322de44a2fadd370acfd2f/chrome/nsChromeProtocolHandler.cpp#141-144
MozReview-Commit-ID: 7ckppZheX3k
Attachment #8833102 - Flags: review?(daniel)
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
Whiteboard: [necko-active]
Attachment #8833102 - Flags: review?(daniel) → review+
https://hg.mozilla.org/mozilla-central/rev/e55efa5a3945
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.