133319 - Crash in file picker

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Tracy Walker [:tracy]]

seen on mas osx commercial build 2002-03-25-08-trunk

-Go to File | Open File
or
-Open a composer window and click on Image insert
-click on Choose file..

Crash in either case.

from crash log:

Date/Time:  2002-03-25 11:12:25 -0800
OS Version: 10.1.3 (Build 5Q45)

Command:    Netscape 6
PID:        292

Exception:  EXC_BAD_ACCESS (0x0001)
Codes:      KERN_PROTECTION_FAILURE (0x0002) at 0x0000007c

Thread 0:
 #0   0x0240baf4 in FileDialogEventHandlerProc__12nsFilePickerFlP8NavCBRecPv
 #1   0x02c62474 in 0x2c62474
 #2   0x739e5960 in Event__C10TNavClientl
 #3   0x739faf28 in Run__11__NavDialog
 #4   0x739f60c8 in NavDialogRun
 #5   0x0240bfec in GetLocalFile__12nsFilePickerFRC8nsStringP6FSSpec
 #6   0x0240b798 in Show__12nsFilePickerFPs
 #7   0x005bce0c in XPTC_InvokeByIndex
 #8   0x005bcd00 in XPTC_InvokeByIndex
 #9   0x01a82964 in 0x1a82964
 #10  0x01a88e3c in XPC_WN_CallMethod__FP9JSContextP8JSObjectUiPlPl
 #11  0x01a0199c in js_Invoke
 #12  0x01a09a70 in 0x1a09a70
 #13  0x01a019f4 in js_Invoke
 #14  0x01a01c40 in js_InternalInvoke
 #15  0x019e2d9c in JS_CallFunctionValue
 #16  0x025232f0 in CallEventHandler__11nsJSContextFPvPvUiPvPii
 #17  0x02542514 in HandleEvent__17nsJSEventListenerFP11nsIDOMEvent
 #18  0x01efa970 in HandleEventSubType__22nsEventListenerManagerFP16nsListenerStru
 #19  0x01efcfb8 in HandleEvent__22nsEventListenerManagerFP14nsIPresConte
 #20  0x02136204 in HandleDOMEvent__12nsXULElementFP14nsIPresContextP7nsEventPP11n
 #21  0x0241522c in DispatchCommandTo__12MenuHelpersXFP16nsIWeakReferenceP10nsICon
 #22  0x0241c4cc in DoCommand__11nsMenuItemXFv
 #23  0x0241274c in CommandEventHandler__10nsMenuBarXFP25OpaqueEventHandlerCallRef
 #24  0x73118b08 in DispatchEventToHandlers
 #25  0x73101d98 in SendEventToEventTargetInternal
 #26  0x731b65b8 in SendEventToEventTarget
 #27  0x7310ba6c in SendHICommandEvent
 #28  0x731a81cc in SendMenuItemSelectedEvent
 #29  0x7318b54c in FinishMenuSelection__FP16OpaqueMenuHandleP10MenuResultn1Ul
 #30  0x731655e0 in MenuSelectCore__FG5PointdUlPP16OpaqueMenuHandlePUs
 #31  0x73187dd4 in MenuSelect
 #32  0x023f9e80 in 0x23f9e80
 #33  0x023f9b1c in DispatchEvent__16nsMacMessagePumpFiP11EventRecord
 #34  0x023f97e0 in DoMessagePump__16nsMacMessagePumpFv
 #35  0x023f915c in Run__10nsAppShellFv
 #36  0x023ac2fc in Run__17nsAppShellServiceFv
 #37  0x004c9224 in main1__FiPPcP11nsISupports
 #38  0x004c9c6c in main

Comment 1

[Tracy Walker [:tracy]]

adding crash & regression keywords

Comment 2

[Conrad Carlen (not reading bugmail)]

CC'ing Steve since he just worked on this

Comment 3

[Mike Pinkerton (not reading bugmail)]

my guess is that this is dagley's

Comment 4

[Bill Law]

Yes, over to Steve.  He is reportedly on his way in and will look at it ASAP.

Comment 5

[Steve Dagley]

Attachment: Fixes NULL being passed as clientData parameter to Nav Services dialogs

The dialog filter now uses the clientData parameter to recover the nsFilePicker
object so passing NULL to the NavServices calls we make is no longer allowed

Comment 6

[Steve Dagley]

Fix checked in

Comment 7

[Tracy Walker [:tracy]]

verified with osx commercial respin 2002-03-25-13-trunk