Closed Bug 1333252 Opened 3 years ago Closed 3 years ago

Move FUZZING definitions from toolkit/moz.configure to js/moz.configure

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: decoder, Assigned: decoder)

References

Details

(Keywords: sec-want, Whiteboard: [adv-main54-])

Attachments

(1 file)

Right now, the FUZZING define and friends (e.g. LIBFUZZER) live in toolkit/moz.configure. However, we also need these defines in the JS engine (e.g. for bug 1332361), which doesn't include this configuration.

Glandium suggested to move the definitions to js/moz.configure instead.

Patch coming up.
Comment on attachment 8829688 [details]
Bug 1333252 - Move FUZZING definition from toolkit to js.

https://reviewboard.mozilla.org/r/106694/#review107754

::: js/moz.configure:252
(Diff revision 1)
> +        if fuzzing and not afl:
> +            return True
> +
> +    set_config('FUZZING', enable_fuzzing)
> +    set_define('FUZZING', enable_fuzzing)
> +    add_old_configure_assignment('FUZZING', enable_fuzzing)

Why add this?

::: js/moz.configure:256
(Diff revision 1)
> +    set_define('FUZZING', enable_fuzzing)
> +    add_old_configure_assignment('FUZZING', enable_fuzzing)
> +
> +    set_config('LIBFUZZER', enable_libfuzzer)
> +    set_define('LIBFUZZER', enable_libfuzzer)
> +    add_old_configure_assignment('LIBFUZZER', enable_libfuzzer)

Same question here.
Attachment #8829688 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8829688 [details]
Bug 1333252 - Move FUZZING definition from toolkit to js.

https://reviewboard.mozilla.org/r/106694/#review107754

> Why add this?

I was under the impression that this is required to make the option work when building the JS shell out-of-tree (standalone), which is a requirement for us. Is that not correct?
Flags: needinfo?(mh+mozilla)
That shouldn't be needed unless you want to use the variable in old-configure.
Flags: needinfo?(mh+mozilla)
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a8134b5899a
Move FUZZING definition from toolkit to js. r=glandium
https://hg.mozilla.org/mozilla-central/rev/6a8134b5899a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Whiteboard: [adv-main54-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.