1333252 - Move FUZZING definitions from toolkit/moz.configure to js/moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Christian Holler (:decoder)]

Right now, the FUZZING define and friends (e.g. LIBFUZZER) live in toolkit/moz.configure. However, we also need these defines in the JS engine (e.g. for bug 1332361), which doesn't include this configuration.

Glandium suggested to move the definitions to js/moz.configure instead.

Patch coming up.

Comment 1

[Christian Holler (:decoder)]

Attachment: Bug 1333252 - Move FUZZING definition from toolkit to js.

Review commit: https://reviewboard.mozilla.org/r/106694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106694/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8829688 [details]
Bug 1333252 - Move FUZZING definition from toolkit to js.

https://reviewboard.mozilla.org/r/106694/#review107754

::: js/moz.configure:252
(Diff revision 1)
> +        if fuzzing and not afl:
> +            return True
> +
> +    set_config('FUZZING', enable_fuzzing)
> +    set_define('FUZZING', enable_fuzzing)
> +    add_old_configure_assignment('FUZZING', enable_fuzzing)

Why add this?

::: js/moz.configure:256
(Diff revision 1)
> +    set_define('FUZZING', enable_fuzzing)
> +    add_old_configure_assignment('FUZZING', enable_fuzzing)
> +
> +    set_config('LIBFUZZER', enable_libfuzzer)
> +    set_define('LIBFUZZER', enable_libfuzzer)
> +    add_old_configure_assignment('LIBFUZZER', enable_libfuzzer)

Same question here.

Comment 3

[Christian Holler (:decoder)]

Comment on attachment 8829688 [details]
Bug 1333252 - Move FUZZING definition from toolkit to js.

https://reviewboard.mozilla.org/r/106694/#review107754

> Why add this?

I was under the impression that this is required to make the option work when building the JS shell out-of-tree (standalone), which is a requirement for us. Is that not correct?

Comment 4

[Mike Hommey [:glandium]]

That shouldn't be needed unless you want to use the variable in old-configure.

Comment 5

[Christian Holler (:decoder)]

Comment on attachment 8829688 [details]
Bug 1333252 - Move FUZZING definition from toolkit to js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106694/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a8134b5899a
Move FUZZING definition from toolkit to js. r=glandium

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6a8134b5899a