Open Bug 1333264 Opened 5 years ago Updated 2 days ago

Intermittent macOS test_master_password.html | Test timed out.

Categories

(Toolkit :: Password Manager, defect, P3)

defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [stockwell disabled])

Attachments

(3 files)

Summary: Intermittent toolkit/components/passwordmgr/test/test_master_password.html | Test timed out. → Intermittent test_master_password.html | Test timed out.
At the current rate I don't think it deserves my attention.
Status: REOPENED → NEW
Flags: needinfo?(MattN+bmo)
Priority: -- → P5
There are 30 failures in the last 7 days, all of them occurred on Linux debug.
Recent log failure: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=167161350

Relevant part of the log:
[task 2018-03-10T11:29:07.678Z] 11:29:07     INFO - Buffered messages finished
[task 2018-03-10T11:29:07.678Z] 11:29:07     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/test_master_password.html | Test timed out. 
[task 2018-03-10T11:29:07.679Z] 11:29:07     INFO -     reportError@SimpleTest/TestRunner.js:121:7
[task 2018-03-10T11:29:07.679Z] 11:29:07     INFO -     TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
[task 2018-03-10T11:29:08.372Z] 11:29:08     INFO - MP change from omgsecret! to 
[task 2018-03-10T11:29:08.374Z] 11:29:08     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-03-10T11:29:08.375Z] 11:29:08     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/test_master_password.html | Cleanup function threw exception: [Exception... "Component returned failure code: 0x805a1ff1 [nsIPK11Token.changePassword]"  nsresult: "0x805a1ff1 (<unknown>)"  location: "JS frame :: chrome://specialpowers/content/specialpowersAPI.js :: doApply :: line 143"  data: no] 
[task 2018-03-10T11:29:08.376Z] 11:29:08     INFO -     executeCleanupFunction@SimpleTest/SimpleTest.js:1219:13
[task 2018-03-10T11:29:08.377Z] 11:29:08     INFO -     SimpleTest.finish@SimpleTest/SimpleTest.js:1230:5
[task 2018-03-10T11:29:08.378Z] 11:29:08     INFO -     killTest@SimpleTest/TestRunner.js:130:7
[task 2018-03-10T11:29:08.379Z] 11:29:08     INFO -     delayedKillTest@SimpleTest/TestRunner.js:157:47
[task 2018-03-10T11:29:08.449Z] 11:29:08     INFO - GECKO(2251) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2018-03-10T11:29:08.450Z] 11:29:08     INFO - GECKO(2251) | MEMORY STAT | vsize 846MB | residentFast 255MB | heapAllocated 68MB
[task 2018-03-10T11:29:08.486Z] 11:29:08     INFO - TEST-OK | toolkit/components/passwordmgr/test/test_master_password.html | took 301138ms
[task 2018-03-10T11:29:11.528Z] 11:29:11     INFO - Error: Unable to restore focus, expect failures and timeouts.
[task 2018-03-10T11:29:11.611Z] 11:29:11    ERROR - /tests/toolkit/components/passwordmgr/test/test_master_password.html logged result after SimpleTest.finish(): Cleanup function threw exception: [Exception... "Component returned failure code: 0x805a1ff1 [nsIPK11Token.changePassword]"  nsresult: "0x805a1ff1 (<unknown>)"  location: "JS frame :: chrome://specialpowers/content/specialpowersAPI.js :: doApply :: line 143"  data: no]
[task 2018-03-10T11:29:11.619Z] 11:29:11     INFO - GECKO(2251) | ++DOMWINDOW == 17 (0xcfcd1000) [pid = 2251] [serial = 31] [outer = 0xcfb196c0]

:MattN Could you please take a look here?
Flags: needinfo?(MattN+bmo)
Whiteboard: [stockwell needswork]
This test only fails on linux32 since that's the only place it runs due to not running with e10s yet (bug 1269039).
Depends on: 1269039
Flags: needinfo?(MattN+bmo)
Priority: P5 → P3
Over the last 7 days there are 36 failures on this bug. These happen on only on Linux.

Here is the most recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=173623190&lineNumber=9644

Here is the relevant part of that log: 

[task 2018-04-13T23:03:21.352Z] 23:03:21     INFO - Buffered messages finished
[task 2018-04-13T23:03:21.353Z] 23:03:21     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/test_master_password.html | Test timed out. 
[task 2018-04-13T23:03:21.353Z] 23:03:21     INFO -     reportError@SimpleTest/TestRunner.js:121:7
[task 2018-04-13T23:03:21.354Z] 23:03:21     INFO -     TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
[task 2018-04-13T23:03:22.020Z] 23:03:22     INFO - MP change from omgsecret! to 
[task 2018-04-13T23:03:22.038Z] 23:03:22     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-04-13T23:03:22.040Z] 23:03:22     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/test_master_password.html | Cleanup function threw exception: [Exception... "Component returned failure code: 0x805a1ff1 [nsIPK11Token.changePassword]"  nsresult: "0x805a1ff1 (<unknown>)"  location: "JS frame :: chrome://specialpowers/content/specialpowersAPI.js :: doApply :: line 132"  data: no] 
[task 2018-04-13T23:03:22.041Z] 23:03:22     INFO -     executeCleanupFunction@SimpleTest/SimpleTest.js:1229:13
[task 2018-04-13T23:03:22.042Z] 23:03:22     INFO -     SimpleTest.finish@SimpleTest/SimpleTest.js:1240:5
[task 2018-04-13T23:03:22.044Z] 23:03:22     INFO -     killTest@SimpleTest/TestRunner.js:130:7
[task 2018-04-13T23:03:22.045Z] 23:03:22     INFO -     delayedKillTest@SimpleTest/TestRunner.js:157:47
[task 2018-04-13T23:03:22.108Z] 23:03:22     INFO - GECKO(2310) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2018-04-13T23:03:22.108Z] 23:03:22     INFO - GECKO(2310) | MEMORY STAT | vsize 831MB | residentFast 239MB | heapAllocated 66MB
[task 2018-04-13T23:03:22.145Z] 23:03:22     INFO - TEST-OK | toolkit/components/passwordmgr/test/test_master_password.html | took 301136ms
[task 2018-04-13T23:03:25.187Z] 23:03:25     INFO - Error: Unable to restore focus, expect failures and timeouts.
[task 2018-04-13T23:03:25.284Z] 23:03:25    ERROR - /tests/toolkit/components/passwordmgr/test/test_master_password.html logged result after SimpleTest.finish(): Cleanup function threw exception: [Exception... "Component returned failure code: 0x805a1ff1 [nsIPK11Token.changePassword]"  nsresult: "0x805a1ff1 (<unknown>)"  location: "JS frame :: chrome://specialpowers/content/specialpowersAPI.js :: doApply :: line 132"  data: no]
[task 2018-04-13T23:03:25.306Z] 23:03:25     INFO - GECKO(2310) | ++DOMWINDOW == 17 (0xdbb90c00) [pid = 2310] [serial = 31] [outer = 0xcf619800]
Flags: needinfo?(MattN+bmo)
Attachment #8970459 - Flags: review?(jmaher)
Comment on attachment 8970459 [details] [diff] [review]
Disabled on linux 32 debug

Review of attachment 8970459 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8970459 - Flags: review?(jmaher) → review+
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by shindli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0480e858c8ea
disabled test_master_password.html on Linux 32 debug for frequent failures. r=jmaher
Keywords: checkin-needed
Flags: needinfo?(MattN+bmo)

Those look like mostly test-verify jobs that got starred to this non-TV bug so I think the volume is much lower than it looked. It's expected that this volume increased because the test was just enabled for e10s. I'll keep an eye on it as I've been fixing other passwordmgr tests.

Flags: needinfo?(MattN+bmo)
Duplicate of this bug: 1522969
Whiteboard: [stockwell disabled]
Whiteboard: [retriggered]

Matthew, 10 failures are TV the rest of them are tier1 mochitest failures - 23 failures in the last 7 days.

There are 53 total failures in the last 7 days. The failure rate is higher and seems to be increasing.

Matthew can you fix this or assign it to someone?

Whiteboard: [retriggered] → [retriggered][stockwell needswork:owner]
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Priority: P3 → P2
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/215984141739
Disable test_master_password.html on Win/Linux pgo/asan/opt due to failures. r=intermittent
Whiteboard: [retriggered][stockwell needswork:owner] → [stockwell disabled]
Assignee: MattN+bmo → nobody
Status: ASSIGNED → NEW
Priority: P2 → P3

This bug has failed 40 times in the last 7 days. Occurs on linux platforms on opt build types.

Recent log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228529262&repo=mozilla-inbound&lineNumber=7689

I intended to disable it on linux opt in comment 80. Did I mess up the syntax?

Flags: needinfo?(dluca)

I'm not entirely sure, but I'm guessing this part here skip-if = os == "linux" is in the wrong place, since its only happening on linux.

Either that, or it needs to be added in another place in the ini so it skips on linux properly.

I use https://wiki.mozilla.org/Auto-tools/Projects/Stockwell/disable-recommended for reference.

Flags: needinfo?(dluca) → needinfo?(MattN+bmo)

Maybe add the skip-if before the scheme = https and also for the (os != 'mac' && (pgo || asan || opt)) isn't it easier to just add (os != 'mac' && !debug)

Also, it might be || instead of &&. Cosmin, can you look?

Flags: needinfo?(csabou)

Hi! We cannot skip on pgo/opt specifically, it's just debug or !debug. I guess the syntax you were looking for was:
skip-if = toolkit == 'android' || asan || os != 'mac' && !debug.
I would in the end go with skip-if = true cause it's affects too many platforms and builds.

Flags: needinfo?(csabou)

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ae65fd31265
Disable test_master_password.html on all platforms due to frequent failures. r=jmaher

Keywords: checkin-needed

I think we want:
skip-if = toolkit == 'android' || (os != 'mac')

:narcis, can you look at this?

Flags: needinfo?(nbeleuzu)
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/318b4b967e7c
Only skip test_master_password.html on platforms with failures.
Flags: needinfo?(MattN+bmo)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #93)

Created attachment 9044902 [details]
Bug 1333264 - Only skip test_master_password.html on platforms with failures. r=jmaher

Uhmm, the toolkit condition is missing, is that how it's supposed to be? I was looking at Comment 92.

Flags: needinfo?(nbeleuzu) → needinfo?(jmaher)

Good eye :apavel, you would make a good sidekick to batman!

in this case, skip-if = !mac, is the same as skipping all platforms except mac. So toolkit == 'android' is covered by !mac.

Flags: needinfo?(jmaher)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #97)

Good eye :apavel, you would make a good sidekick to batman!

in this case, skip-if = !mac, is the same as skipping all platforms except mac. So toolkit == 'android' is covered by !mac.

:D

Thanks for clarifying this!

Duplicate of this bug: 1269867
Duplicate of this bug: 1624808
Summary: Intermittent test_master_password.html | Test timed out. → Intermittent macOS test_master_password.html | Test timed out.
You need to log in before you can comment on or make changes to this bug.