1333288 - assert failure in wr_profiler_set_enabled()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

When I updated "gfx.webrender.profiler.enable" pref from "about:config", assert of wr_profiler_set_enabled() was failed. It was called from main thread.


-----------------------------

#[no_mangle]
pub extern fn wr_profiler_set_enabled(window: &mut WrWindowState, enabled: bool)
{
    assert!( unsafe { is_in_compositor_thread() });
    window.renderer.set_profiler_enabled(enabled);
}

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - call wr_profiler_set_enabled() on compositor thread

Comment 2

[Sotaro Ikeda [:sotaro]]

attachment 8829714 [details] [diff] [review] is not ideal, but it seems ok as temporary solution. wr_profiler_set_enabled() is going to be removed when render thread is enabled.

Comment 3

[Nicolas Silva [:nical]]

Comment on attachment 8829714 [details] [diff] [review]
patch - call wr_profiler_set_enabled() on compositor thread

Review of attachment 8829714 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, although I have a preference towards only allowing CompositorBridgeParent::SetWebRenderProfilerEnabled to be called on the compositor thread. and have the pref callback that calls it take care of remoting to the proper thread.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Nicolas Silva [:nical] from comment #3)
> Comment on attachment 8829714 [details] [diff] [review]
> patch - call wr_profiler_set_enabled() on compositor thread
> 
> Review of attachment 8829714 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is fine, although I have a preference towards only allowing
> CompositorBridgeParent::SetWebRenderProfilerEnabled to be called on the
> compositor thread. and have the pref callback that calls it take care of
> remoting to the proper thread.

Yea, I agree. But the patch seems ok as a short time solution.

Comment 5

[Sotaro Ikeda [:sotaro]]

https://hg.mozilla.org/projects/graphics/rev/6ec880339dd40e91bf5ea204afbb73887bce1f3c

Comment 6

[Kartikaya Gupta (email:[e-mail])]

The commit message is missing the bug number. I'll do a backout/reland with that fixed and DONTBUILD to avoid rerunning builds on it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/12cb4acdb646
call wr_profiler_set_enabled() on compositor thread r=nical DONTBUILD