Closed Bug 1333289 Opened 3 years ago Closed 3 years ago

Add a web API to retrieve debugging data from the media element in an asynchronous way

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

This is an asyn version of bug 1236703 because some media objects (ex: MDSM) can only be accessed off the main thread.
Assignee: nobody → jwwang
Blocks: 1331833
Priority: -- → P3
Comment on attachment 8829751 [details]
Bug 1333289. Part 2 - retrieve debugging data from MediaDecoder/MDSM.

https://reviewboard.mozilla.org/r/106758/#review107776
Attachment #8829751 - Flags: review?(jyavenard) → review+
Comment on attachment 8829750 [details]
Bug 1333289. Part 1 - add a function to the webidl to retrieve debugging data in an asynchronous way.

https://reviewboard.mozilla.org/r/106756/#review108010

::: dom/html/HTMLMediaElement.cpp:1480
(Diff revision 1)
> +HTMLMediaElement::MozRequestDebugInfo()
> +{
> +  ErrorResult rv;
> +  RefPtr<Promise> promise = CreateDOMPromise(rv);
> +  if (NS_WARN_IF(rv.Failed())) {
> +    return nullptr;

r-, returns null without saying so in the IDL.

What you _probably_ wanted was to mark it [NewObject] and then throw on the incoming ErrorResult...
Attachment #8829750 - Flags: review?(bzbarsky) → review-
Comment on attachment 8829750 [details]
Bug 1333289. Part 1 - add a function to the webidl to retrieve debugging data in an asynchronous way.

https://reviewboard.mozilla.org/r/106756/#review108122

r=me
Attachment #8829750 - Flags: review?(bzbarsky) → review+
Thanks for the reviews!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a910c074e14
Part 1 - add a function to the webidl to retrieve debugging data in an asynchronous way. r=bz
https://hg.mozilla.org/integration/autoland/rev/e72c737ab6ed
Part 2 - retrieve debugging data from MediaDecoder/MDSM. r=jya
(In reply to Phil Ringnalda (:philor) from comment #10)
> Backed out in https://hg.mozilla.org/integration/autoland/rev/95df6209f125
> for ASan mda thread-related leaks,
> https://treeherder.mozilla.org/logviewer.html#?job_id=71765321&repo=autoland

I don't think my patches are responsible for the leaks which are produced by webrtc. Furthermore, the code added by this bug will only be called by the about:media plug-in.
Or, maybe you made a new flavor of the bug 1326399 leak more common, or, maybe it was pure coincidence that it was more common right then, dunno.
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b68c0c1ae045
Part 1 - add a function to the webidl to retrieve debugging data in an asynchronous way. r=bz
https://hg.mozilla.org/integration/autoland/rev/0f69481eb5ad
Part 2 - retrieve debugging data from MediaDecoder/MDSM. r=jya
https://hg.mozilla.org/mozilla-central/rev/b68c0c1ae045
https://hg.mozilla.org/mozilla-central/rev/0f69481eb5ad
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.