Closed Bug 1333493 Opened 3 years ago Closed 3 years ago
_COMPONENT to js/* files
:jorendorff, can you help me out and recommend bugzilla components for either specific files, file patterns, or sub directories?
For what it's worth, /js/src/moz.build already contains a few mappings we made in the past.
excellent, possibly we can quickly validate those and ensure the other files under js/* have a reasonable component.
proposed patch in case the answer is simple :)
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
thanks for the feedback, this patch should do the trick!
checking in here- it has been 2 weeks...feel free to redirect the review as needed.
:naveed- can you help me find someone to review this patch and the patch in bug 1344878?
I did the initial work for js/src, I'll steal the review to help things move forward.
Attachment #8833284 - Flags: review?(jorendorff) → review+
thanks for the notes, I have moved the work to the top of the file, but on the second point, I see some issues: it appears the ../ notation doesn't work for BUG_COMPONENTS: $ ./mach file-info bugzilla-component js/public/** UNKNOWN js/public/CallArgs.h js/public/CallNonGenericMethod.h js/public/CharacterEncoding.h js/public/Class.h js/public/Conversions.h js/public/Date.h js/public/Debug.h js/public/GCAPI.h js/public/GCAnnotations.h js/public/GCHashTable.h js/public/GCPolicyAPI.h js/public/GCVariant.h js/public/GCVector.h js/public/HashTable.h js/public/HeapAPI.h js/public/Id.h js/public/Initialization.h js/public/LegacyIntTypes.h js/public/MemoryMetrics.h js/public/Principals.h js/public/ProfilingFrameIterator.h js/public/ProfilingStack.h js/public/Proxy.h js/public/Realm.h js/public/RefCounted.h js/public/RequiredDefines.h js/public/Result.h js/public/RootingAPI.h js/public/SliceBudget.h js/public/StructuredClone.h js/public/SweepingAPI.h js/public/TraceKind.h js/public/TracingAPI.h js/public/TrackedOptimizationInfo.h js/public/TypeDecls.h js/public/UbiNode.h js/public/UbiNodeBreadthFirst.h js/public/UbiNodeCensus.h js/public/UbiNodeDominatorTree.h js/public/UbiNodePostOrder.h js/public/UbiNodeShortestPaths.h js/public/UniquePtr.h js/public/Utility.h js/public/Value.h js/public/Vector.h js/public/WeakMapPtr.h I took a stab at moving all of existing ../public references to the new root level js/moz.build file. I know you wanted to avoid that which I tried to do until I realized it wasn't working for ../public. If you are not comfortable with this, possibly we can look at working on the moz.build code for handing BUG_COMPONENTS.
forgot to pick up recent changes, this looks right
Comment on attachment 8850464 [details] [diff] [review] add BUG_COMPONENT to js/* Review of attachment 8850464 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me; would the lines for public/ files from js/src/moz.build need to be removed, then? (rs=me for that) Thanks! ::: js/moz.build @@ +4,5 @@ > + > +with Files("**"): > + BUG_COMPONENT = component_engine > + > +with Files("examples/**"): Out of curiosity, doesn't the line `with Files("**")` already cover the examples, ipc and public directories? (as well as ductwork/debugger) @@ +13,5 @@ > + > +with Files('public/**'): > + BUG_COMPONENT = component_engine > + > +for header in ('GCAnnotations.h', 'GCAPI.h', 'HeapAPI.h', 'RootingAPI.h', 'SliceBudget.h', 'SweepingAPI.h', 'TraceKind.h', 'TracingAPI.h', 'WeakMapPtr.h'): Can you please add here: GCHashTable.h, GCPolicyAPI.h, GCVariant.h, GCVector.h? @@ +20,5 @@ > + > +with Files('public/TrackedOptimizationInfo.h'): > + BUG_COMPONENT = component_jit > + > + nit: 2 unnecessary blank lines at EOF
Attachment #8850464 - Attachment is obsolete: false
Comment on attachment 8850470 [details] [diff] [review] add BUG_COMPONENT to js/* Review of attachment 8850470 [details] [diff] [review]: ----------------------------------------------------------------- oops, mid-air collision; see above comments, some of which still apply here. Thanks!
Attachment #8850470 - Flags: review?(bbouvier) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/91d1dce57468 add BUG_COMPONENT to js/* files. r=bbouvier
You need to log in before you can comment on or make changes to this bug.