Stop copy/pasting the skippability implementation from DOMEventTargetHelper all over

RESOLVED FIXED in Firefox 54

Status

()

Core
DOM
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

We have multiple copies of this.  Some apparently try to avoid checking for non-wrapper gcthings, some just seem to have no reason for being at all.

I'm going to just common these up, since we have all the facilities to do it.
Created attachment 8830005 [details] [diff] [review]
Common up the skippability implementations that are basically copy/pastes of the DOMEventTargetHelper one
Attachment #8830005 - Flags: review?(bugs)
Comment on attachment 8830005 [details] [diff] [review]
Common up the skippability implementations that are basically copy/pastes of the DOMEventTargetHelper one

This relies on the skippability inheritance changes in the other bug I guess
Attachment #8830005 - Flags: review?(bugs) → review+
> This relies on the skippability inheritance changes in the other bug I guess

It actually doesn't.  Without those changes things that are _INHERITED are skippable if and only if their rootmost participant is.  Which DETH's participant is, so all these things are skippable anyway.

Comment 4

11 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fd0b1d9a60a
Common up the skippability implementations that are basically copy/pastes of the DOMEventTargetHelper one.  r=smaug

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8fd0b1d9a60a
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.