Crash in nsRangeFrame::GetValueAtEventPoint on linux

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bholley, Assigned: jwatt)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Comment 1

2 years ago
Looks like we end up taking this path:

http://searchfox.org/mozilla-central/rev/02a56df6474a97cf84d94bbcfaa126979970905d/widget/gtk/gtk3drawing.cpp#2557

Which stores 0 in thumb_height. Not sure if this is a bug in gecko's expectations or in the gtk glue.
Flags: needinfo?(jwatt)
(Assignee)

Comment 2

2 years ago
I'd guess this is a bug in gecko's expectations. The |style| passed through to gtk_style_context_get includes the orientation of the control. I'd guess it leaves/sets the dimension perpendicular to the thumb's direction of travel as/to zero. This code doesn't care about that dimension anyway so we should change the assertion to only assert about the dimension that matters to us.
Flags: needinfo?(jwatt)
(Assignee)

Comment 3

2 years ago
Created attachment 8832268 [details] [diff] [review]
patch
Assignee: nobody → jwatt
Attachment #8832268 - Flags: review?(mstange)
Attachment #8832268 - Flags: review?(mstange) → review+

Comment 4

2 years ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f130bfec2d5
Fix crash in nsRangeFrame::GetValueAtEventPoint on linux. r=mstange

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9f130bfec2d5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.