Closed
Bug 1333543
Opened 7 years ago
Closed 7 years ago
Crash in nsRangeFrame::GetValueAtEventPoint on linux
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: bholley, Assigned: jwatt)
Details
Attachments
(1 file)
1.54 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
STR: (1) Load https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/reftests/forms/input/range/range-orient-horizontal.html on a linux debug build (2) click the range. We trip the following assertion: http://searchfox.org/mozilla-central/rev/02a56df6474a97cf84d94bbcfaa126979970905d/layout/forms/nsRangeFrame.cpp#565 Looks like the width is 840 but the height is 0.
Reporter | ||
Comment 1•7 years ago
|
||
Looks like we end up taking this path: http://searchfox.org/mozilla-central/rev/02a56df6474a97cf84d94bbcfaa126979970905d/widget/gtk/gtk3drawing.cpp#2557 Which stores 0 in thumb_height. Not sure if this is a bug in gecko's expectations or in the gtk glue.
Flags: needinfo?(jwatt)
Assignee | ||
Comment 2•7 years ago
|
||
I'd guess this is a bug in gecko's expectations. The |style| passed through to gtk_style_context_get includes the orientation of the control. I'd guess it leaves/sets the dimension perpendicular to the thumb's direction of travel as/to zero. This code doesn't care about that dimension anyway so we should change the assertion to only assert about the dimension that matters to us.
Flags: needinfo?(jwatt)
Assignee | ||
Comment 3•7 years ago
|
||
Assignee: nobody → jwatt
Attachment #8832268 -
Flags: review?(mstange)
Updated•7 years ago
|
Attachment #8832268 -
Flags: review?(mstange) → review+
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/9f130bfec2d5 Fix crash in nsRangeFrame::GetValueAtEventPoint on linux. r=mstange
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9f130bfec2d5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•