1333556 - WebIDL callbacks should assert that their incoming rv is not already failing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Apparently people think this is a reasonable way to call an IDL callback:

    ErrorResult result;
    result.Throw(rv);
    const nsAString& reason = NS_LITERAL_STRING("Error pairing.");
    aCallback.PairingFailed(reason, result);
    ENSURE_SUCCESS_VOID(result);

but of course this is nonsense, because we're throwing on the _outparam_.  IDL callbacks should assert against this.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Assert that an ErrorResult passed to a WebIDL callback as an outparam is not already-failed

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7b337b06065
Assert that an ErrorResult passed to a WebIDL callback as an outparam is not already-failed.  r=peterv

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e7b337b06065