Fix case of dangling pointer during FragmentOrElement unlinking

RESOLVED FIXED in Firefox 54

Status

()

Core
DOM
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: tobytailor, Assigned: tobytailor)

Tracking

53 Branch
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
Improperly unregistering intersection observers in DOMIntersectionObserver::unobserved causes a crash in mozilla::dom::DOMIntersectionObserver::UnlinkTarget due to usage of a dangling pointer.
(Assignee)

Updated

9 months ago
Blocks: 1321865
Comment hidden (mozreview-request)
Assignee: nobody → tschneider

Comment 2

9 months ago
mozreview-review
Comment on attachment 8830067 [details]
Bug 1333580 - Properly unregister last unobserved target.

https://reviewboard.mozilla.org/r/106984/#review108044
Attachment #8830067 - Flags: review?(mrbkap) → review+
(Assignee)

Updated

9 months ago
Keywords: checkin-needed

Comment 3

9 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3a822b9c8543
Properly unregister last unobserved target. r=mrbkap
Keywords: checkin-needed

Comment 4

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3a822b9c8543
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.