Closed Bug 1333589 Opened 9 years ago Closed 9 years ago

Convert SiteIdentityPopup events to bundle events

Categories

(GeckoView :: General, defect)

defect
Not set
normal

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(3 files)

No description provided.
Convert the onButtonClick method to provide GeckoBundle as the response.
Attachment #8830062 - Flags: review?(s.kaspari)
Convert the events used in SiteIdentityPopup to bundle events. UI thread events are used because the listeners perform operations on the UI thread.
Attachment #8830063 - Flags: review?(s.kaspari)
Convert the "Permissions:*" and "Session:Reload" observers to events that go through GlobalEventDispatcher.
Attachment #8830064 - Flags: review?(s.kaspari)
Attachment #8830062 - Flags: review?(s.kaspari) → review+
Attachment #8830063 - Flags: review?(s.kaspari) → review+
Attachment #8830064 - Flags: review?(s.kaspari) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/edeef4fcdb7b 1. Use GeckoBundle for DoorHanger.OnButtonClickListener; r=sebastian https://hg.mozilla.org/integration/mozilla-inbound/rev/114c35019621 2. Convert SiteIdentityPopup events to bundle events; r=sebastian https://hg.mozilla.org/integration/mozilla-inbound/rev/c09b8f1c7934 3. Convert SiteIdentityPopup observers to events; r=sebastian
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 54 → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: