Add support for snapshotting to the render thread

RESOLVED FIXED in mozilla54

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

9 months ago
Created attachment 8830083 [details] [diff] [review]
Add support for snapshotting with the RenderThread.
Assignee: nobody → jmuizelaar
Attachment #8830083 - Flags: review?(nical.bugzilla)

Updated

9 months ago
Attachment #8830083 - Flags: review?(nical.bugzilla) → review+

Updated

9 months ago
Blocks: 1333565

Comment 2

9 months ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/50cb9a3e39ac
Add support for snapshotting with the RenderThread. r=nical
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED

Comment 3

9 months ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/4ff35aa90692
Add support for snapshotting with the RenderThread. r=nical
WebRenderAPI::Readback() uses wr_readback_into_buffer(). Dont't we need to use  wr_renderer_readback() here?

https://hg.mozilla.org/projects/graphics/annotate/tip/gfx/webrender_bindings/WebRenderAPI.cpp#l199
Flags: needinfo?(nical.bugzilla)
(In reply to Sotaro Ikeda [:sotaro] from comment #4)
> WebRenderAPI::Readback() uses wr_readback_into_buffer(). Dont't we need to
> use  wr_renderer_readback() here?
> 

Ah! yes indeed.
Flags: needinfo?(nical.bugzilla)

Updated

8 months ago
Depends on: 1337281
Blocks: 1337649
Depends on: 1337661
Depends on: 1337821
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.