Removing a connected IRC account can lead to warnings on log removal

NEW
Unassigned

Status

Thunderbird
Instant Messaging
2 years ago
a year ago

People

(Reporter: aleth, Unassigned)

Tracking

53 Branch

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
This is as disconnection is async for IRC (a QUIT message is sent to the server and then the server ends the session.)

Account is still disconnecting while we attempt to remove logs.  logger.js:822
(Reporter)

Comment 1

2 years ago
Current code flow (since bug 1322473):

RemoveIncomingServer
  LogoutofServer
    Shutdown
      disconnect()
  RemoveFiles
    deleteLogFiles
  ClearAllValues
    remove IM account

It should be possible for RemoveFiles to not call deleteLogFiles directly, but instead to wait until the account removed notification.

There is some overlap here with a WIP of abdelrhman.
Flags: needinfo?(ab)
(Reporter)

Updated

2 years ago
Summary: Removing a connected IRC account can lead to warnings → Removing a connected IRC account can lead to warnings on log removal
(In reply to aleth [:aleth] from comment #1)
> Current code flow (since bug 1322473):
> 
> RemoveIncomingServer
>   LogoutofServer
>     Shutdown
>       disconnect()
>   RemoveFiles
>     deleteLogFiles
>   ClearAllValues
>     remove IM account
> 
> It should be possible for RemoveFiles to not call deleteLogFiles directly,
> but instead to wait until the account removed notification.
> 
> There is some overlap here with a WIP of abdelrhman.

Yes, IIRC it's the same mechanism of deleting account in canceling registration (e.g. use aDeleteOnServer flag)
Flags: needinfo?(a.ahmed1026)
You need to log in before you can comment on or make changes to this bug.