Closed Bug 1333635 Opened 8 years ago Closed 8 years ago

safety guards for in-tree treeherder transforms

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jonasfj, Unassigned)

Details

@dustin, I assume we're using some transform to create treeherder routes and extra data... Upgrading taskcluster-treeherder I noticed a lot of tasks like: https://queue.taskcluster.net/v1/task/VAtJvKCtTnCfK2AkQUpPaA They get ignored by taskcluster-treeherder because they are missing: task.extra.treeherder (and appropriate properties of this object) Can we change the in-tree transform to guard against creating tasks with only some of the properties required for treeherder? Either all of none, should be present. Note: currently this is a silent error, the task just doesn't show up on treeherder.
Flags: needinfo?(dustin)
That is a BBB job, so we should be removing the route where we remove the task.extra.treeherder. Adding a consistency check is a good idea too!
Flags: needinfo?(dustin)
Right, sorry, background there is: Buildbot will send info to treeherder, so we deliberately do *not* want the TC task shown in treeherder.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.