[devtools-html] Better error messages when webpack fails

RESOLVED FIXED in Firefox 54

Status

()

Firefox
Developer Tools: Inspector
P3
enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

53 Branch
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

For now the error messages we get when webpack fails to build the inspector bundle are very cryptic:

> Error
>    at NormalModule.<anonymous> (devtools\client\inspector\node_modules\devtools-launchpad\node_modules\webpack\lib\NormalModule.js:113:20)
>    at NormalModule.onModuleBuild (devtools\client\inspector\node_modules\webpack-core\lib\NormalModuleMixin.js:310:10)
>    at nextLoader (devtools\client\inspector\node_modules\webpack-core\lib\NormalModuleMixin.js:275:25)
>    at devtools\client\inspector\node_modules\webpack-core\lib\NormalModuleMixin.js:292:15
>    at runSyncOrAsync (devtools\client\inspector\node_modules\webpack-core\lib\NormalModuleMixin.js:160:12)
>    at nextLoader (devtools\client\inspector\node_modules\webpack-core\lib\NormalModuleMixin.js:290:3)
>    at devtools\client\inspector\node_modules\webpack-core\lib\NormalModuleMixin.js:259:5
>    at Storage.finished (devtools\client\inspector\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:38:16)
>    at devtools\client\inspector\node_modules\graceful-fs\graceful-fs.js:78:16
>    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:415:3)

We can do something better by creating a webpack plugin.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8830218 [details]
Bug 1333717 - devtools-html: better webpack error messages;

https://reviewboard.mozilla.org/r/107108/#review108220

Yay, error messages! Thanks!
Attachment #8830218 - Flags: review?(pbrosset) → review+

Comment 3

a year ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a4e47e8a576
devtools-html: better webpack error messages;r=pbro

Comment 4

a year ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50f4ccdd925f
fix eslint failure in devtools inspector webpack config;r=me

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0a4e47e8a576
https://hg.mozilla.org/mozilla-central/rev/50f4ccdd925f
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.