1333749 - Mirrored and incorrect inset box-shadow with large border radius

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[Markus Stange [:mstange]]

Attachment: testcase

In the testcase, there should only be one white circle, not two.

Comment 1

[Markus Stange [:mstange]]

Attachment: another testcase without spread

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:Layout is broken

sion window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b5541adf77a4eeb1f237828e1bd6b8076bafd1f3&tochange=edefce9fdb67ed34c50e2db610ab9b7f60041da0

Regressed by: Bug 1250037

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: verify that inset box shadows are symmetric before attempting to mirror them

So, for inset box shadows, the whitespace rect can be placed in a non-symmetric manner inside the outside rect depending on user input. This checks for that before we attempt to mirror it.

Comment 4

[Marcia Knous [:marcia]]

Tracking 53/54+ for this layout regression.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/63aba54a7342
verify that inset box shadows are symmetric before attempting to mirror them. r=mchang

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/63aba54a7342

Comment 7

[Lee Salzman [:lsalzman]]

Comment on attachment 8830452 [details] [diff] [review]
verify that inset box shadows are symmetric before attempting to mirror them

Approval Request Comment
[Feature/Bug causing the regression]: bug 1250037, 53+
[User impact if declined]: Inset box shadows with an offset will fail to render properly.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]: aurora (53)
[Is the change risky?]: no
[Why is the change risky/not risky?]: This just disables an optimization added in bug 1250037 from being used when it is not applicable. 
[String changes made/needed]: None

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8830452 [details] [diff] [review]
verify that inset box shadows are symmetric before attempting to mirror them

Fixes a recent regression, Aurora53+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

(In reply to Lee Salzman [:lsalzman] from comment #7)
> [Is this code covered by automated tests?]: yes

Was the attached testcase supposed to have landed as a reftest?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d78356134309

Comment 11

[Lee Salzman [:lsalzman]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)
> (In reply to Lee Salzman [:lsalzman] from comment #7)
> > [Is this code covered by automated tests?]: yes
> 
> Was the attached testcase supposed to have landed as a reftest?

The testcase as it is can't land as a reftest. It would require reworking.