Closed Bug 1333759 Opened 7 years ago Closed 6 years ago

Intermittent devtools/client/aboutdebugging/test/browser_service_workers_fetch_flag.js | All service workers were removed from the list. -

Categories

(DevTools :: about:debugging, defect, P5)

Product:
DevTools
Component:
about:debugging
Type:
defect

Tracking

(firefox55 disabled, firefox56 disabled)

Status:
RESOLVED INCOMPLETE
Tracking Flags:
Tracking Status
firefox55 --- disabled
firefox56 --- disabled

People

(Reporter: intermittent-bug-filer, Assigned: jdescottes)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other])

Attachments

(1 file)

Bug 1333759 - use waitUntil instead of mutations in aboutdebugging test helper;
59 bytes, text/x-review-board-request
ochameau
: review+
Details
Component: Developer Tools → Developer Tools: about:debugging
Aboutdebugging triage. Filter on TRIAGE-JD201705
Low frequency intermittent.
Priority: -- → P3
this has been pretty frequent on osx opt, e10s only.  here is a recent log:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=109821991&lineNumber=1786

there is too much text in the log to realistically paste in here, but maybe this first failure is interesting:
16:00:11     INFO - TEST-PASS | devtools/client/aboutdebugging/test/browser_service_workers_fetch_flag.js | Service worker registration unregistered - 
16:00:11     INFO - Buffered messages finished
16:00:11     INFO - TEST-UNEXPECTED-FAIL | devtools/client/aboutdebugging/test/browser_service_workers_fetch_flag.js | All service workers were removed from the list. - 
16:00:11     INFO - Stack trace:
16:00:11     INFO -     chrome://mochitests/content/browser/devtools/client/aboutdebugging/test/browser_service_workers_fetch_flag.js:testBody:35
16:00:11     INFO -     Tester_execTest@chrome://mochikit/content/browser-test.js:774:9
16:00:11     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:686:7
16:00:11     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
16:00:11     INFO - Removing tab.
16:00:11     INFO - Waiting for event: 'TabClose' on [object XULElement].
16:00:11     INFO - Got event: 'TabClose' on [object XULElement].
16:00:11     INFO - Tab removed and finished closing
16:00:11     INFO - Closing about:debugging
16:00:11     INFO - Removing tab.
16:00:11     INFO - Waiting for event: 'TabClose' on [object XULElement].
16:00:11     INFO - Got event: 'TabClose' on [object XULElement].
16:00:11     INFO - Tab removed and finished closing
16:00:11     INFO - opening about:debugging
16:00:11     INFO - Adding a new tab with URL: about:debugging#workers
16:00:11     INFO - GECKO(1753) | *************************
16:00:11     INFO - GECKO(1753) | A coding exception was thrown in a Promise resolution callback.
16:00:11     INFO - GECKO(1753) | See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
16:00:11     INFO - GECKO(1753) | Full message: TypeError: this.transport is null
16:00:11     INFO - GECKO(1753) | Full stack: send@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/main.js:1521:5

:jdescottes- I know there is a work week (a great chance to hack on this!) with possibly conflicting priorities- is there any chance you can find someone from the about:debugging team to look into this bug in the next 2 weeks?
Flags: needinfo?(jdescottes)
Whiteboard: [stockwell needswork]
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ba60c226b0e
Skip test browser_service_workers_fetch_flag.js, on osx, for intermittent failures; r=me,test-only
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell disabled]
(In reply to Joel Maher ( :jmaher) (afk until july 12) from comment #13)
> this has been pretty frequent on osx opt, e10s only.  here is a recent log:
> https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-
> inbound&job_id=109821991&lineNumber=1786
> 
> :jdescottes- I know there is a work week (a great chance to hack on this!)
> with possibly conflicting priorities- is there any chance you can find
> someone from the about:debugging team to look into this bug in the next 2
> weeks?

Sorry Joel, did not find anytime to work on this for now :( Test has now been disabled, keeping the ni? to look at it when possible.
this started failing again, this time on linux64-

:jdescottes can you look into this test again so we don't end up in a while disabling this for linux as well?
Whiteboard: [stockwell disabled] → [stockwell needswork]
Let's see if using waitUntil instead of mutations improves the stability of the test:
- try with waitUntil : https://treeherder.mozilla.org/#/jobs?repo=try&revision=3778a8a2e53677826e43cdc9fb0abb30e010e993
- try with central: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c5cd693e69482002b2bc28a0a43496a7dbe15d8
On ~150 runs, got two failures for central, 0 with the patch, so looks like this should be an improvement. Will clean it up and submit for review.
Flags: needinfo?(jdescottes)
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8900034 [details]
Bug 1333759 - use waitUntil instead of mutations in aboutdebugging test helper;

https://reviewboard.mozilla.org/r/171366/#review178458

Looks good, but i'm wondering if waitUntil interval is too aggressive:
http://searchfox.org/mozilla-central/source/devtools/client/shared/test/head.js#198
It is only 10ms, it may slow down the test and lead to timeouts on slow hardware.
Attachment #8900034 - Flags: review?(poirot.alex) → review+
Looking at the runs on my two try pushes, the ones with the fix seem to be ~15% slower (2200ms average, versus 1900 right now).
I admit that 10ms worried me too. I'll try a push a bigger interval.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d17398b0dcfc
use waitUntil instead of mutations in aboutdebugging test helper;r=ochameau
No failures since comment 35 landed; anything else to do here?
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell fixed:other]
Bulk priority update of open intermittent test failure bugs. 

P3 => P5

https://bugzilla.mozilla.org/show_bug.cgi?id=1381960
Priority: P3 → P5
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: