1333794 - remember password prompt has awkward extra spacing with new "Show password" checkbox

Status: RESOLVED WORKSFORME

(Firefox :: Untriaged, defect)

Description

[clourriv]

Attachment: extra space above button and below "Show password" field

the spacing is awkward in the remember password prompt since "Show password" was added. the button which appears on the bottom right should probably either be moved up so that it's next to "Show password", or at the very least not have 2 lines of empty space above it. see attached screen capture. there's now a bunch of empty space above the button and below the "Show password" field.

Comment 1

[Vlad Bacia-Mociran [:VladB]]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
 
Hi clourriv. On latest Nightly the Password Manager prompt has changed. It will be available in future releases. Firefox latest release for the moment has the old Password Manager prompt.

Here is a Pushlog with the changes that were made: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=abecacadf9d3006029eb2208445521f495e80a70&tochange=2e3bef583561c4812e6093a5ec639b1a58d0ab18

Can you please retest this using latest Nightly build (https://nightly.mozilla.org/) and report back the results ? When doing this, please use a new clean Firefox profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/AR5o9d).

Comment 2

[Fahima Zulfath]

Does the bug happens in latest version of browser?
It will be good to get some steps to reproduce or an URL to check with browsers.
Is there a minimized testcase or URL we can use to test? 

[bugday-20170130]

Comment 3

[clourriv]

indeed, the spacing isn't so egregious in nightly 54

Comment 4

[Vlad Bacia-Mociran [:VladB]]

@clourriv, as per comment 3, do you think that we can close this bug ?

Comment 5

[clourriv]

yes, i think it's fine