XULTabAccessible needs to implement HyperTextAccessibleWrap

RESOLVED FIXED in Firefox 54

Status

()

Core
Disability Access APIs
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: yzen, Assigned: yzen)

Tracking

unspecified
mozilla54
All
Windows
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
Right now on windows we hit 

NS_ASSERTION(nsAccUtils::IsTextInterfaceSupportCorrect(this),
  "Does not support Text when it should");

for xul tabs when trying to resolve a role here:
https://dxr.mozilla.org/mozilla-central/source/accessible/windows/msaa/AccessibleWrap.cpp?q=NS_ASSERTION%28nsAccUtils%3A%3AIsTextInterfaceSupportCorrect%28this%29%2C&redirect_type=single#438
(Assignee)

Comment 1

9 months ago
Note this is for debug builds only.
(Assignee)

Comment 2

9 months ago
Created attachment 8830418 [details] [diff] [review]
1333843 patch
Attachment #8830418 - Flags: review?(surkov.alexander)

Comment 3

9 months ago
Comment on attachment 8830418 [details] [diff] [review]
1333843 patch

Review of attachment 8830418 [details] [diff] [review]:
-----------------------------------------------------------------

Adding some background of the problem, which we discussed with Yura over irc.

A browser tab contains a text node for a tab label and a close tab button. I believe that the text node is exposed in accessible name of a tab, so there's no need to expose it over text interface, however we don't have a good way to hide it, and its presence shouldn't break the user experience anyway. It'd be good to double check the latter with Marco though.
Attachment #8830418 - Flags: review?(surkov.alexander)
Attachment #8830418 - Flags: review+
Attachment #8830418 - Flags: feedback?(mzehe)

Comment 4

9 months ago
Comment on attachment 8830418 [details] [diff] [review]
1333843 patch

I don't see why this should have adverse effects on the user experience. f=me.
Attachment #8830418 - Flags: feedback?(mzehe) → feedback+

Comment 5

9 months ago
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1c00a1914de
xultab accessible needs to support HyperTextAccessibleWrap. r=surkov

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f1c00a1914de
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.