1333878 - Thunderbird 52.0b1 mac repacks failing

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Wayne Mery (:wsmwk)]

+++ This bug was initially created as a clone of Bug #1297786 +++

Mac repacks all failing.

From https://archive.mozilla.org/pub/thunderbird/candidates/52.0b1-candidates/build1/logs/release-comm-beta-macosx64_repack_2-bm85-build1-build17.txt.gz

Reexecuting in the virtualenv
Adding configure options from /builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/.mozconfig
  --enable-crashreporter
  --enable-release
  --enable-js-shell
  --enable-application=mail
  --enable-update-channel=beta
  --disable-install-strip
  --enable-profiling
  --with-l10n-base=../../l10n
  --disable-compile-environment
  --enable-calendar
  --enable-official-branding

DSYMUTIL=/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/mozilla/../clang/bin/llvm-dsymutil
  SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE=/builds/crash-stats-api.token

CC=/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/mozilla/../clang/bin/clang

CXX=/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/mozilla/../clang/bin/clang++

LDFLAGS=-B/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/mozilla/../cctools/bin -Wl,-no_data_in_code_info

LLVMCONFIG=/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/mozilla/../clang/bin/llvm-config
  MOZ_ADDON_SIGNING=0
  MOZ_REQUIRE_SIGNING=1
  MOZ_REQUIRE_ADDON_SIGNING=0
Traceback (most recent call last):
  File "/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/configure.py", line 32, in <module>
    sys.exit(main(sys.argv))
  File "/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/configure.py", line 24, in main
    sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
  File "/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/mozilla/python/mozbuild/mozbuild/configure/__init__.py", line 344, in run
    self._value_for(option)
  File "/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/mozilla/python/mozbuild/mozbuild/configure/__init__.py", line 409, in _value_for
    return self._value_for_option(obj)
  File "/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/mozilla/python/mozbuild/mozbuild/util.py", line 925, in method_call
    cache[args] = self.func(instance, *args)
  File "/builds/slave/tb-rel-c-beta-m64_rpk_2-000000/comm-beta/mozilla/python/mozbuild/mozbuild/configure/__init__.py", line 475, in _value_for_option
    % option_string.split('=', 1)[0])
mozbuild.configure.options.InvalidOptionError: CC is not available in this configuration
*** Fix above errors and then restart with               "make -f client.mk build"
    raise CalledProcessError(retcode, cmd)

Comment 1

[aleth [:aleth]]

Looks like Beta is using mail/config/mozconfigs/macosx64/l10n-mozconfig, which includes local-mozconfig.common, which sets CC. This is not new, but the incompatibility check is new in 52.

Comment 2

[aleth [:aleth]]

Attachment: Don't include local-mozconfig.common for OS X release repacks to avoid setting compiler vars

Including build/mozconfig.common directly instead of via local-mozconfig.common avoids setting the variables incompatible with --disable-compile-environment. I don't think there is anything else relevant to repacks in local-mozconfig.common.

Comment 3

[aleth [:aleth]]

Comment on attachment 8830525 [details] [diff] [review]
Don't include local-mozconfig.common for OS X release repacks to avoid setting compiler vars

Actually, no need to bother glandium with this, as it's c-c only.

Comment 4

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/c0e5b93e1369ec16a2c0747df816fbcae5084fff
Bug 1333878 - Don't include local-mozconfig.common for OS X release repacks to avoid setting compiler vars. r=Fallen

Comment 5

[aleth [:aleth]]

Comment on attachment 8830525 [details] [diff] [review]
Don't include local-mozconfig.common for OS X release repacks to avoid setting compiler vars

Obviously this is needed on beta ;)

[Approval Request Comment]
Testing completed (on c-c, etc.): Only affects beta & release

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8830525 [details] [diff] [review]
Don't include local-mozconfig.common for OS X release repacks to avoid setting compiler vars

You want to see whether it works on C-C first? You want me to do the uplift or will you? (I'd suggest a DONTBUILD at least on Aurora.)

Comment 7

[aleth [:aleth]]

(In reply to Jorg K (GMT+1) from comment #6)
> You want to see whether it works on C-C first? You want me to do the uplift
> or will you? (I'd suggest a DONTBUILD at least on Aurora.)

It does not affect c-c or c-a at all (I should have pushed with DONTBUILD on c-c), so you can uplift these whenever it is convenient (i.e. before you retrigger the next beta build). Btw the next push on c-a should ideally be without DONTBUILD so that the recent landings get picked up by the next c-a nightly.

Comment 8

[Jorg K (CEST = GMT+2)]

C-A (TB 53): https://hg.mozilla.org/releases/comm-aurora/rev/39a2fa56ce9a8a9fcdda279ca564c3530d7347ff
C-B (TB 52): https://hg.mozilla.org/releases/comm-beta/rev/4355665025083d93915c96100b8716a19dd7b50e

Comment 9

[Wayne Mery (:wsmwk)]

Thanks all. That worked great