Closed
Bug 1333898
Opened 8 years ago
Closed 8 years ago
MessageChannel messaging incorrectly sets .source on the MessageEvent, as far as I can tell
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: baku)
Details
Attachments
(1 file)
|
1.58 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
This is leading to a test failure in testing/web-platform/tests/workers/postMessage_event_properties.htm on this line:
assert_equals(evt.source, null, "source");
Per spec at https://html.spec.whatwg.org/multipage/comms.html#dom-messageport-postmessage as far as I can tell "source" never gets set so should be null...
Note that "source" _is_ expected to be present for "connect" events on SharedWorkerGlobalScope, but not for the MessageChannel case, afaict....
Flags: needinfo?(kyle)
Flags: needinfo?(amarchesini)
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → amarchesini
Flags: needinfo?(kyle)
Flags: needinfo?(amarchesini)
|
Reporter | |
Comment 1•8 years ago
|
||
Also note that I could be misreading the spec and the test could be bogus. So please double-check me on this!
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8830728 -
Flags: review?(kyle)
|
||
Updated•8 years ago
|
Attachment #8830728 -
Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b310f568584
MessageChannel messaging sets .ports to null, r=qdot
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•