ErrorEvent, CloseEvent, ProgressEvent and FileList should be exposed in workers

RESOLVED FIXED in Firefox 54

Status

()

Core
DOM: Events
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: bz, Assigned: smaug)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(2 attachments)

It's silly, because we totally have ErrorEvent _objects_ in workers (e.g. we fire them for script errors!) but don't expose the ErrorEvent interface.  Is there any particular reason to have things this way?

Note that at least testing/web-platform/meta/workers/semantics/interface-objects/003.html.ini and testing/web-platform/meta/workers/semantics/interface-objects/001.worker.js.ini will need to be modified if this is fixed.
Flags: needinfo?(bugs)
No reason. Looks like ErrorEvent (webidl) has been that way since it was added in bug 643325
Assignee: nobody → bugs
Flags: needinfo?(bugs)
Summary: ErrorEvent should be exposed in workers → ErrorEvent, CloseEvent, ProgressEvent and FileList should be exposed in workers
Created attachment 8830555 [details] [diff] [review]
expose_interfaces_in_workers.diff

We dispatch those events in workers and FileList can be posted to worker.
(We have some tests for FileList posting)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=257e96d399dca55adefb1b2b92134fcbb153f14c
Attachment #8830555 - Flags: review?(amarchesini)
Attachment #8830555 - Flags: review?(amarchesini) → review+
Oh, I need to add stuff to test_serviceworker_interfaces.html too
And mark test passing: TEST-UNEXPECTED-PASS | /FileAPI/idlharness.worker.html
Created attachment 8830769 [details] [diff] [review]
more unexpected test pass fixing

Comment 5

9 months ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47828603cd9c
ErrorEvent, CloseEvent, ProgressEvent and FileList should be exposed in workers, r=baku

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/47828603cd9c
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.