Closed
Bug 1333903
Opened 7 years ago
Closed 7 years ago
ErrorEvent, CloseEvent, ProgressEvent and FileList should be exposed in workers
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: smaug)
Details
Attachments
(2 files)
|
9.51 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
15.66 KB,
patch
|
Details | Diff | Splinter Review |
It's silly, because we totally have ErrorEvent _objects_ in workers (e.g. we fire them for script errors!) but don't expose the ErrorEvent interface. Is there any particular reason to have things this way? Note that at least testing/web-platform/meta/workers/semantics/interface-objects/003.html.ini and testing/web-platform/meta/workers/semantics/interface-objects/001.worker.js.ini will need to be modified if this is fixed.
Flags: needinfo?(bugs)
|
Assignee | |
Comment 1•7 years ago
|
||
No reason. Looks like ErrorEvent (webidl) has been that way since it was added in bug 643325
Assignee: nobody → bugs
Flags: needinfo?(bugs)
|
|
Assignee | |
Updated•7 years ago
|
Summary: ErrorEvent should be exposed in workers → ErrorEvent, CloseEvent, ProgressEvent and FileList should be exposed in workers
|
|
Assignee | |
Comment 2•7 years ago
|
||
We dispatch those events in workers and FileList can be posted to worker. (We have some tests for FileList posting) https://treeherder.mozilla.org/#/jobs?repo=try&revision=257e96d399dca55adefb1b2b92134fcbb153f14c
Attachment #8830555 -
Flags: review?(amarchesini)
|
||
Updated•7 years ago
|
Attachment #8830555 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Oh, I need to add stuff to test_serviceworker_interfaces.html too And mark test passing: TEST-UNEXPECTED-PASS | /FileAPI/idlharness.worker.html
|
|
Assignee | |
Comment 4•7 years ago
|
||
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/47828603cd9c ErrorEvent, CloseEvent, ProgressEvent and FileList should be exposed in workers, r=baku
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/47828603cd9c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•