Closed Bug 1333905 Opened 9 years ago Closed 9 years ago

Documentation for browser.notification.getAll() is incorrect

Categories

(Developer Documentation Graveyard :: Add-ons, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: e.chechurin, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.67 Safari/537.36 Steps to reproduce: Used a notification API like so: browser.notification.getAll().then(function (results) { console.log(results) }) Actual results: `results` contains a chrome-like object value. Expected results: `results` should contain "... an array of strings, each of which is the ID of a currently active notification." source: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/notifications/getAll
Bug 1254359 definitely looks related. Are you on Nightly, Dev Edition, Beta, or Release?
Component: Notifications and Alerts → WebExtensions: Untriaged
Flags: needinfo?(e.chechurin)
Component: WebExtensions: Untriaged → Add-ons
Product: Toolkit → Developer Documentation
Summary: notification.getAll() result is not WebExtension-compatible → Documentation for browser.notification.getAll() is incorrect
Version: 50 Branch → unspecified
Thanks for filing this. I've updated the page. Bob, would you mind checking (especially "Return value" and the examples). https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/notifications/getAll
Flags: needinfo?(bob.silverberg)
You welcome. Guys, on a separate note - do you have plan to add Typescript typings for 'browser'? We have covered a bunch of stuff in our project (based on chrome typings), and I thought maybe we can help with 'official' typings?
(In reply to e.chechurin from comment #4) > You welcome. > > Guys, on a separate note - do you have plan to add Typescript typings for > 'browser'? That's interesting! I don't know, personally, but I suggest you'll get better responses if you ask on the dev-addons mailing list: https://mail.mozilla.org/listinfo/dev-addons.
Looks great, thanks Will!
Flags: needinfo?(bob.silverberg)
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: needinfo?(e.chechurin)
You need to log in before you can comment on or make changes to this bug.