1333915 - Replace spawns and bridges in PPluginModule with endpoints

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Andrew McCreight [:mccr8]]

PContent contains:
  parent spawns PPluginModule;
PPluginModule contains:
  bridges PContent, PPluginModule;

Presumably these will need to be converted at the same time.

Comment 1

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c159bfb391d5924523462a0699f928511d9aa2e

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1333915, part 1 - Don't open the channel in CommonInit.

The next patch will open the channel differently in each case, so move
that code into the callers.

Review commit: https://reviewboard.mozilla.org/r/107640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107640/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1333915, part 2 - Stop using bridges and spawns in plugins.

The old bridges message was nested(inside_cpows) async, because the
content process is calling up to the chrome process in a sync message,
and we need the call back down into the content process to be finished
before we return. However, the actual combination nested(inside_cpows)
async is banned in IPDL for some reason. Instead, I made the
InitPluginModuleParent message, which replaces the bridge message,
sync. Doing this required making both that and the LoadPlugin message
nested(inside_sync) for some reason.

Once I removed the bridges and got it working, I was just able to
remove the spawns from the IPDL file and it worked.

Review commit: https://reviewboard.mozilla.org/r/107642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107642/

Comment 4

[Andrew McCreight [:mccr8]]

I have an idea to avoid the weirdness of the nested messages. I should be able to just return the endpoint via the original sync message to the parent.

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8830984 [details]
Bug 1333915, part 1 - Don't open the channel in CommonInit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107640/diff/1-2/

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 8830985 [details]
Bug 1333915, part 2 - Stop using bridges and spawns in plugins.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107642/diff/1-2/

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 8830984 [details]
Bug 1333915, part 1 - Don't open the channel in CommonInit.

https://reviewboard.mozilla.org/r/107640/#review109588

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 8830985 [details]
Bug 1333915, part 2 - Stop using bridges and spawns in plugins.

https://reviewboard.mozilla.org/r/107642/#review109626

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af954ecc38aa
part 1 - Don't open the channel in CommonInit. r=jimm
https://hg.mozilla.org/integration/autoland/rev/5e502d481d6c
part 2 - Stop using bridges and spawns in plugins. r=jimm

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/af954ecc38aa
https://hg.mozilla.org/mozilla-central/rev/5e502d481d6c