Closed Bug 1333927 Opened 6 years ago Closed 6 years ago

ScrollAreaEvent should be cycle collected

Categories

(Core :: DOM: Events, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: bkelly, Assigned: masayuki)

Details

(Whiteboard: [MemShrink])

Attachments

(1 file)

ScrollAreaEvent extends a cycle collected class UIEvent.  It also contains a cycle collected DOMRect member field.  Therefore ScrollAreaEvent should declare:

NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED(ScrollAreaEvent, UIEvent)

And then in the cpp:

NS_IMPL_CYCLE_COLLECTION_INHERITED(ScrollAreaEvent, UIEvent, mClientArea)
Whiteboard: [MemShrink]
Priority: -- → P2
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Component: DOM → DOM: Events
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → Trunk
Comment on attachment 8831601 [details]
Bug 1333927 Make ScrollAreaEvent::mClientArea cycle collected

https://reviewboard.mozilla.org/r/108152/#review109212
Attachment #8831601 - Flags: review?(bugs) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/b332a2a48c1b
Make ScrollAreaEvent::mClientArea cycle collected r=smaug
https://hg.mozilla.org/mozilla-central/rev/b332a2a48c1b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.