1333927 - ScrollAreaEvent should be cycle collected

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

ScrollAreaEvent extends a cycle collected class UIEvent.  It also contains a cycle collected DOMRect member field.  Therefore ScrollAreaEvent should declare:

NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED(ScrollAreaEvent, UIEvent)

And then in the cpp:

NS_IMPL_CYCLE_COLLECTION_INHERITED(ScrollAreaEvent, UIEvent, mClientArea)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8231cf88a3f

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1333927 Make ScrollAreaEvent::mClientArea cycle collected

ScrollAreaEvent extends a cycle collected class UIEvent.  It also contains a cycle collected DOMRect member field.

Review commit: https://reviewboard.mozilla.org/r/108152/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108152/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8831601 [details]
Bug 1333927 Make ScrollAreaEvent::mClientArea cycle collected

https://reviewboard.mozilla.org/r/108152/#review109212

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b332a2a48c1b
Make ScrollAreaEvent::mClientArea cycle collected r=smaug

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b332a2a48c1b