Disable emulated ETC formats on ANGLE

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox53 fixed, firefox54 fixed)

Details

Attachments

(1 attachment)

It's better to not offer these on ANGLE because they are emulated, which is worse quality without the expected perf gains from using compressed textures.
Assignee: nobody → jgilbert
Comment on attachment 8830520 [details]
Bug 1333930 - Disable ETC textures on ANGLE, where they are emulated. -

https://reviewboard.mozilla.org/r/107274/#review108840

LGTM
Attachment #8830520 - Flags: review?(dmu) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13c1d368da47
Disable ETC textures on ANGLE, where they are emulated. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5cbf0ee1014
Update ES3 compressed texture test's ext name.
Comment on attachment 8830520 [details]
Bug 1333930 - Disable ETC textures on ANGLE, where they are emulated. -

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: Users may unexpectedly get slow ETC performance.
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It removes advertisement of an emulated feature, following course set by the WebGL working group.
[String changes made/needed]: none
Attachment #8830520 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/13c1d368da47
https://hg.mozilla.org/mozilla-central/rev/f5cbf0ee1014
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Modified from Uplift Dashboard.
Comment on attachment 8830520 [details]
Bug 1333930 - Disable ETC textures on ANGLE, where they are emulated. -

Makes sense, Aurora53+
Attachment #8830520 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.