Closed Bug 1333937 Opened 4 years ago Closed 4 years ago

SSL gtests call the Connected function twice

Categories

(NSS :: Test, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mt, Assigned: mt)

Details

This just causes more log-spam and a small amount of extra work.
https://nss-review.dev.mozaws.net/D175
Assignee: nobody → martin.thomson
https://hg.mozilla.org/projects/nss/rev/b1e8a6f492a41a5a90c9785d72eaeddfa8c8cc64
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.30
This seems to make problems on PPC and AArch64 [1]. (Not sure why those platforms.) Reverting this change makes the intermittent go away.

[1] https://pastebin.mozilla.org/8978605
Status: RESOLVED → REOPENED
Flags: needinfo?(martin.thomson)
Resolution: FIXED → ---
Only do something in Connected() if the state is not STATE_CONNECTED
https://hg.mozilla.org/projects/nss/rev/16d0354d7968b4a4238f6f917f0a8d012d13a41d
This solves the issues we've seen.
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Flags: needinfo?(martin.thomson)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.