Closed Bug 1333939 Opened 3 years ago Closed 3 years ago

Remove -Wno-invalid-constexpr from clang-cl config

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

Details

Attachments

(1 file)

I spot-checked a few other warnings in the list, and we still need to keep them.

Notably, we still need -Wno-ignored-attributes, but now for a different reason!
Attached patch constexprSplinter Review
Assignee: nobody → dmajor
Attachment #8830535 - Flags: review?(nfroyd)
Comment on attachment 8830535 [details] [diff] [review]
constexpr

Review of attachment 8830535 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming the JS engine got rid of those dllimport specs/

::: old-configure.in
@@ -1096,5 @@
>              # At least one MSVC header and several headers in-tree have
>              # unused typedefs, so turn this on.
>              CXXFLAGS="$CXXFLAGS -Wno-unused-local-typedef"
> -            # Several JS engine header files use __declspec(dllimport) on
> -            # classes, and clang-cl helpfully warns about its non-support

Did we delete this dllimport attributes?  They used to be *very* spammy?
Attachment #8830535 - Flags: review?(nfroyd) → review+
I didn't go and find the change, but we must have. When I built without -Wno-ignored-attr, the only hits I got for "grep ignored-attr" were all from jemalloc. (And for that reason the warning stays disabled anyway; I've only updated the comment)
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e55d80cc4a8
Remove -Wno-invalid-constexpr from clang-cl config. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/9e55d80cc4a8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.