Closed
Bug 133397
Opened 23 years ago
Closed 22 years ago
Bug in SECMOD_UpdateModule
Categories
(NSS :: Libraries, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
3.5
People
(Reporter: wtc, Assigned: rrelyea)
References
Details
(Whiteboard: [adt2 RTM])
I saw this while reviewing the code in pk11util.c:
SECStatus SECMOD_UpdateModule(SECMODModule *module)
{
SECStatus result;
result = SECMOD_DeletePermDB(module);
if (result == SECSuccess) {
}
result = SECMOD_AddPermDB(module);
return result;
}
The empty body of the if statement is obviously wrong.
I think the SECMOD_AddPermDB call should be moved inside
the if?
|
Reporter | |
Comment 1•22 years ago
|
||
Changed the QA contact to Bishakha.
QA Contact: sonja.mirtitsch → bishakhabanerjee
|
Assignee | |
Updated•22 years ago
|
Target Milestone: --- → 3.5
|
|
Reporter | |
Comment 2•22 years ago
|
||
This is not a serious problem, but the fix is simple.
Bob, could you check it into the tip?
Severity: normal → minor
Priority: -- → P1
|
|
Assignee | |
Comment 3•22 years ago
|
||
Done.
bob
|
|
Reporter | |
Comment 4•22 years ago
|
||
Thanks, Bob. Marked the bug fixed.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 5•22 years ago
|
||
Verified fixed in rev. 1.33 of pk11util.c.
Status: RESOLVED → VERIFIED
|
||
Comment 6•22 years ago
|
||
adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch. Pls check this in
asap. thanks!
|
|
Reporter | |
Updated•22 years ago
|
Keywords: adt1.0.1+ → fixed1.0.1
You need to log in
before you can comment on or make changes to this bug.
Description
•