Closed Bug 133397 Opened 22 years ago Closed 22 years ago

Bug in SECMOD_UpdateModule

Categories

(NSS :: Libraries, defect, P1)

Product:
NSS
Component:
Libraries
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: wtc, Assigned: rrelyea)

References

Details

(Whiteboard: [adt2 RTM]) 

I saw this while reviewing the code in pk11util.c:

SECStatus SECMOD_UpdateModule(SECMODModule *module)
{
    SECStatus result;

    result = SECMOD_DeletePermDB(module);

    if (result == SECSuccess) {
    }
        result = SECMOD_AddPermDB(module);
    return result;
}
The empty body of the if statement is obviously wrong.
I think the SECMOD_AddPermDB call should be moved inside
the if?
Changed the QA contact to Bishakha.
QA Contact: sonja.mirtitsch → bishakhabanerjee
Target Milestone: --- → 3.5
This is not a serious problem, but the fix is simple.
Bob, could you check it into the tip?
Severity: normal → minor
Priority: -- → P1
Done.

bob
Thanks, Bob.  Marked the bug fixed.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Verified fixed in rev. 1.33 of pk11util.c.
Status: RESOLVED → VERIFIED
Blocks: 145836
adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch. Pls check this in
asap. thanks!
Blocks: 143047
Keywords: adt1.0.1+, nsbeta1+
Whiteboard: [adt2 RTM]
Keywords: adt1.0.1+ → fixed1.0.1
You need to log in before you can comment on or make changes to this bug.