Closed Bug 1334012 Opened 3 years ago Closed 5 months ago

nsLoginManager runs in both parent and child processes (remove autoCompleteSearchAsync from nsILoginManager)

Categories

(Toolkit :: Password Manager, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [passwords:tech-debt] [passwords:generation] [skyline] )

Attachments

(1 file)

For the most part nsLoginManager is provides wrappers around storage-related methods (other than the *LoginSavingEnabled/getAllDisabledHosts ones they need to run in the parent) and some initialization related to observers, and autoCompleteSearchAsync to return autocomplete results to satchel.

If we move autoCompleteSearchAsync to its own interface with an implementation in the content process (e.g. LoginManagerContent.jsm) we should be able to stop running nsLoginManager in the content process and then can enforce that LoginManager.jsm can only be run in the parent process.

There may be a call or two to getLoginSavingEnabled from content but that's fine as we can move the implementation of those methods to somewhere like LoginHelper.jsm and have the nsLoginManager implementation use that helper since I believe the permission manager (where login saving permissions are now stored) is fine to be read in both processes.
Priority: -- → P3
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Type: defect → task
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/8049711eaaf9
Move Login AutoComplete to its own interface. r=jaws

Backed out changeset 8049711eaaf9 (Bug 1334012) for autocomplete failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8049711eaaf944348ba3097264b98af40ed337f1&selectedJob=244279394

Backout link: https://hg.mozilla.org/integration/autoland/rev/569aec33bccb48a4c91ec0fdbf1109430b6b113e

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=244279394&repo=autoland

[task 2019-05-02T19:58:49.841Z] 19:58:49 INFO - TEST-START | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_https_upgrade.html
[task 2019-05-02T19:58:49.857Z] 19:58:49 INFO - GECKO(2248) | ++DOMWINDOW == 35 (0xde7de400) [pid = 2248] [serial = 35] [outer = 0xde726230]
[task 2019-05-02T19:58:50.870Z] 19:58:50 INFO - [2223, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-05-02T19:58:50.931Z] 19:58:50 INFO - GECKO(2248) | ++DOMWINDOW == 36 (0xda52c000) [pid = 2248] [serial = 36] [outer = 0xde726230]
[task 2019-05-02T19:58:51.013Z] 19:58:51 INFO - [2223, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-05-02T19:58:51.602Z] 19:58:51 INFO - GECKO(2248) | [2248, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 120
[task 2019-05-02T19:58:51.639Z] 19:58:51 INFO - GECKO(2248) | TEST-PASS | http://mochi.test:8888/tests/toolkit/components/passwordmgr/test/mochitest/parent_utils.js | Got autocomplete popup - {"mInput":null,"mPopupOpen":false,"_currentIndex":0} == true
[task 2019-05-02T19:58:52.381Z] 19:58:52 INFO - GECKO(2248) | --DOCSHELL 0xe200a000 == 11 [pid = 2248] [id = {dbada4b9-6a42-43fa-8437-1e1b6fc58bf3}] [url = moz-extension://7339ba7e-6ef6-4af8-b04b-a727df6f771b/_generated_background_page.html]
[task 2019-05-02T19:58:52.442Z] 19:58:52 INFO - GECKO(2248) | [2248, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 120
[task 2019-05-02T19:58:52.458Z] 19:58:52 INFO - GECKO(2248) | [2248, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 120
[task 2019-05-02T19:58:52.479Z] 19:58:52 INFO - GECKO(2248) | [2248, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 120
[task 2019-05-02T19:58:52.501Z] 19:58:52 INFO - GECKO(2248) | [2248, Main Thread] WARNING: 'aRv.Failed()', file /builds/worker/workspace/build/src/dom/ipc/StructuredCloneData.cpp, line 120
[task 2019-05-02T19:58:52.563Z] 19:58:52 INFO - GECKO(2248) | ++DOCSHELL 0xdb876400 == 12 [pid = 2248] [id = {de698b87-769e-4718-8ea5-17e888410f1b}]
[task 2019-05-02T19:58:52.565Z] 19:58:52 INFO - GECKO(2248) | ++DOMWINDOW == 37 (0xda45d680) [pid = 2248] [serial = 37] [outer = (nil)]
[task 2019-05-02T19:58:52.581Z] 19:58:52 INFO - GECKO(2248) | TEST-PASS | http://mochi.test:8888/tests/toolkit/components/passwordmgr/test/mochitest/pwmgr_common_parent.js | Access LoginManager - true == true
[task 2019-05-02T19:58:52.583Z] 19:58:52 INFO - GECKO(2248) | TEST-PASS | http://mochi.test:8888/tests/toolkit/components/passwordmgr/test/mochitest/pwmgr_common_parent.js | Not expecting logins to be present - 0 == 0
[task 2019-05-02T19:58:52.627Z] 19:58:52 INFO - GECKO(2248) | TEST-PASS | http://mochi.test:8888/tests/toolkit/components/passwordmgr/test/mochitest/pwmgr_common_parent.js | Checking for successful init login - 0 == 0
[task 2019-05-02T19:58:52.631Z] 19:58:52 INFO - GECKO(2248) | TEST-PASS | http://mochi.test:8888/tests/toolkit/components/passwordmgr/test/mochitest/pwmgr_common_parent.js | Checking for no disabled hosts - 0 == 0
[task 2019-05-02T19:58:52.653Z] 19:58:52 INFO - GECKO(2248) | ++DOMWINDOW == 38 (0xdbf60c00) [pid = 2248] [serial = 38] [outer = 0xda45d680]
[task 2019-05-02T19:58:52.832Z] 19:58:52 INFO - [2223, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-05-02T19:58:52.868Z] 19:58:52 INFO - GECKO(2248) | ++DOMWINDOW == 39 (0xdbf65400) [pid = 2248] [serial = 39] [outer = 0xda45d680]
[task 2019-05-02T19:58:53.017Z] 19:58:53 INFO - GECKO(2248) | --DOMWINDOW == 38 (0xe32d5890) [pid = 2248] [serial = 11] [outer = (nil)] [url = moz-extension://7339ba7e-6ef6-4af8-b04b-a727df6f771b/_generated_background_page.html]
[task 2019-05-02T19:58:53.155Z] 19:58:53 INFO - GECKO(2248) | console.warn: nsLoginManager: "searchLogins: formSubmitURL or httpRealm is recommended"
[task 2019-05-02T19:58:53.251Z] 19:58:53 INFO - GECKO(2248) | [2248, Main Thread] WARNING: '!mLoginManagerAC', file /builds/worker/workspace/build/src/toolkit/components/satchel/nsFormFillController.cpp, line 714
[task 2019-05-02T19:58:55.997Z] 19:58:55 INFO - GECKO(2248) | --DOMWINDOW == 37 (0xde7de400) [pid = 2248] [serial = 35] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:55.998Z] 19:58:55 INFO - GECKO(2248) | --DOMWINDOW == 36 (0xde7d7000) [pid = 2248] [serial = 34] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:55.999Z] 19:58:55 INFO - GECKO(2248) | --DOMWINDOW == 35 (0xde591800) [pid = 2248] [serial = 27] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:55.999Z] 19:58:55 INFO - GECKO(2248) | --DOMWINDOW == 34 (0xdb661c00) [pid = 2248] [serial = 30] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:56.001Z] 19:58:55 INFO - GECKO(2248) | --DOMWINDOW == 33 (0xe3791400) [pid = 2248] [serial = 24] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:56.001Z] 19:58:55 INFO - GECKO(2248) | --DOMWINDOW == 32 (0xe294a400) [pid = 2248] [serial = 22] [outer = (nil)] [url = moz-extension://7339ba7e-6ef6-4af8-b04b-a727df6f771b/_generated_background_page.html]
[task 2019-05-02T19:58:56.002Z] 19:58:55 INFO - GECKO(2248) | --DOMWINDOW == 31 (0xe207a000) [pid = 2248] [serial = 16] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:56.003Z] 19:58:55 INFO - GECKO(2248) | --DOMWINDOW == 30 (0xe2012c00) [pid = 2248] [serial = 15] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:56.003Z] 19:58:55 INFO - GECKO(2248) | --DOMWINDOW == 29 (0xe2011400) [pid = 2248] [serial = 14] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:56.003Z] 19:58:56 INFO - GECKO(2248) | --DOMWINDOW == 28 (0xe2010800) [pid = 2248] [serial = 13] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:56.005Z] 19:58:56 INFO - GECKO(2248) | --DOMWINDOW == 27 (0xe200b800) [pid = 2248] [serial = 12] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:56.005Z] 19:58:56 INFO - GECKO(2248) | --DOMWINDOW == 26 (0xe06b6800) [pid = 2248] [serial = 26] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:58:56.005Z] 19:58:56 INFO - GECKO(2248) | --DOMWINDOW == 25 (0xe294e400) [pid = 2248] [serial = 5] [outer = (nil)] [url = about:blank]
[task 2019-05-02T19:59:04.222Z] 19:59:04 INFO - GECKO(2248) | [2248, StreamTrans #5] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/modules/libjar/nsJARChannel.cpp, line 371
[task 2019-05-02T19:59:04.223Z] 19:59:04 INFO - GECKO(2248) | [2248, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /builds/worker/workspace/build/src/modules/libjar/nsJARChannel.cpp, line 994
[task 2019-05-02T19:59:04.883Z] 19:59:04 INFO - GECKO(2248) | --DOMWINDOW == 24 (0xdbf60c00) [pid = 2248] [serial = 38] [outer = (nil)] [url = about:blank]
[task 2019-05-02T20:03:49.841Z] 20:03:49 INFO - TEST-INFO | started process screentopng
[task 2019-05-02T20:03:50.125Z] 20:03:50 INFO - TEST-INFO | screentopng: exit 0
[task 2019-05-02T20:03:50.126Z] 20:03:50 INFO - Buffered messages logged at 19:58:52
[task 2019-05-02T20:03:50.127Z] 20:03:50 INFO - add_task | Entering test setup
[task 2019-05-02T20:03:50.127Z] 20:03:50 INFO - add_task | Leaving test setup
[task 2019-05-02T20:03:50.127Z] 20:03:50 INFO - add_task | Entering test test_empty_first_entry
[task 2019-05-02T20:03:50.128Z] 20:03:50 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_https_upgrade.html | Checking form-basic username is:
[task 2019-05-02T20:03:50.128Z] 20:03:50 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_https_upgrade.html | Checking form-basic password is:
[task 2019-05-02T20:03:50.128Z] 20:03:50 INFO - Buffered messages logged at 19:58:53
[task 2019-05-02T20:03:50.128Z] 20:03:50 INFO - TEST-PASS | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_https_upgrade.html | Check popup is initially closed
[task 2019-05-02T20:03:50.128Z] 20:03:50 INFO - Buffered messages finished
[task 2019-05-02T20:03:50.130Z] 20:03:50 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_https_upgrade.html | Test timed out.
[task 2019-05-02T20:03:50.130Z] 20:03:50 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-05-02T20:03:50.130Z] 20:03:50 INFO - reportError@SimpleTest/TestRunner.js:121:22
[task 2019-05-02T20:03:50.132Z] 20:03:50 INFO - TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
[task 2019-05-02T20:03:50.132Z] 20:03:50 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-05-02T20:03:50.132Z] 20:03:50 INFO - setTimeout handler
TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-05-02T20:03:50.132Z] 20:03:50 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-05-02T20:03:50.133Z] 20:03:50 INFO - setTimeout handler
TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-05-02T20:03:50.133Z] 20:03:50 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-05-02T20:03:50.133Z] 20:03:50 INFO - setTimeout handler
TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-05-02T20:03:50.133Z] 20:03:50 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-05-02T20:03:50.134Z] 20:03:50 INFO - setTimeout handler
TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-05-02T20:03:50.134Z] 20:03:50 INFO - setTimeout handlerTestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-05-02T20:03:50.134Z] 20:03:50 INFO - setTimeout handler
TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
[task 2019-05-02T20:03:50.135Z] 20:03:50 INFO - TestRunner.runTests/<@SimpleTest/TestRunner.js:381:20
[task 2019-05-02T20:03:50.135Z] 20:03:50 INFO - promise callbackTestRunner.runTests@SimpleTest/TestRunner.js:368:50
[task 2019-05-02T20:03:50.136Z] 20:03:50 INFO - RunSet.runtests@SimpleTest/setup.js:201:14
[task 2019-05-02T20:03:50.136Z] 20:03:50 INFO - RunSet.runall@SimpleTest/setup.js:180:12
[task 2019-05-02T20:03:50.137Z] 20:03:50 INFO - hookupTests@SimpleTest/setup.js:273:12
[task 2019-05-02T20:03:50.137Z] 20:03:50 INFO - parseTestManifest@http://mochi.test:8888/manifestLibrary.js:36:5
[task 2019-05-02T20:03:50.137Z] 20:03:50 INFO - getTestManifest/req.onload@http://mochi.test:8888/manifestLibrary.js:49:11
[task 2019-05-02T20:03:50.138Z] 20:03:50 INFO - EventHandlerNonNull
getTestManifest@http://mochi.test:8888/manifestLibrary.js:45:3
[task 2019-05-02T20:03:50.138Z] 20:03:50 INFO - hookup@SimpleTest/setup.js:253:5
[task 2019-05-02T20:03:50.139Z] 20:03:50 INFO - EventHandlerNonNull*@http://mochi.test:8888/tests?autorun=1&closeWhenDone=1&consoleLevel=INFO&manifestFile=tests.json&dumpOutputDirectory=%2Ftmp&cleanupCrashes=true:11:1
[task 2019-05-02T20:03:50.927Z] 20:03:50 INFO - GECKO(2248) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-05-02T20:03:50.927Z] 20:03:50 INFO - GECKO(2248) | MEMORY STAT | vsize 685MB | residentFast 274MB | heapAllocated 74MB
[task 2019-05-02T20:03:50.948Z] 20:03:50 INFO - TEST-OK | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_https_upgrade.html | took 301110ms

Flags: needinfo?(MattN+bmo)

Try lied due to bug 1547040 :(

Flags: needinfo?(MattN+bmo)
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/59549c837955
Move Login AutoComplete to its own interface. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: qe-verify-
Whiteboard: [passwords:tech-debt] → [passwords:tech-debt] [passwords:generation] [skyline]
You need to log in before you can comment on or make changes to this bug.