1334115 - Data review for 'Add session/usage data core ping'

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Metrics, defect)

Description

[Barbara Bermes [:barbara] - NI please!]

Data stewards, please review data added in https://bugzilla.mozilla.org/show_bug.cgi?id=1243595

Legal bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=1279308

Chenxia, as a data steward for Android, do you know if we've added this to  https://gecko.readthedocs.io/en/latest/mobile/android/fennec/index.html?

No expiration date.

Comment 1

[Benjamin Smedberg]

The way data review works is that we review the changes to the data documentation, not the code itself. I looked through the changes linked in bug 1243595 and there were no documentation changes included there.

I looked through blame for https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/docs/data/core-ping.rst?q=file%3Acore-ping&redirect_type=single and found this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1273684

Which led to this change: https://hg.mozilla.org/mozilla-central/annotate/05adfc869721/toolkit/components/telemetry/docs/core-ping.rst#l48

Barbara, who on your team can verify that this doc accurately represents the data the client is sending on both Android and iOS?

Comment 2

[Barbara Bermes [:barbara] - NI please!]

Ok, now I'm confused, is it Georg or Chenxia who is in charge of making sure that any addition to the core ping is documented in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/docs/data/core-ping.rst.

Based on the logs, it's Georg. 

session and duration have been added to the doc. So I think we are good there.

Comment 3

[Georg Fritzsche [:gfritzsche]]

Data collection review for mobile is Chenxia.
I can help with technical/code review for our Telemetry code and give feedback on the documents.

Comment 4

[Chenxia Liu [:liuche]]

I looked at the patches landed in that bug (https://hg.mozilla.org/mozilla-central/rev/557018e8059e) and it looks good, matches the documentation - only incrementing the session counts and keeping track of the cumulative session durations.

The documentation is also present in rtd.io, although it's not in the Firefox for Android section (but rather in the Telemetry > Data Documentation section, although it does specify that it is mobile-specific) at https://gecko.readthedocs.io/en/latest/toolkit/components/telemetry/telemetry/data/core-ping.html .

I'm going to close this as FIXED. Thanks Barbara!