133412 - Allow building with CodeWarrior Pro 7.2

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Simon Fraser [no longer active]]

Bug for tracking build changes required to move to CodeWarrior Pro 7.2

Comment 1

[Simon Fraser [no longer active]]

Attachment: xpidl_prefix.h: include <Files.h> before <OpenTransport.h>

Comment 2

[Simon Fraser [no longer active]]

Attachment: Remove the #pragma optimization_level hack from the JavaScript prefix file

Comment 3

[Simon Fraser [no longer active]]

Attachment: macsocket.h: include <Files.h> before <OpenTransport.h>

Comment 4

[Simon Fraser [no longer active]]

Attachment: macsockotpt.c: include <Files.h> before <OpenTransport.h>

Comment 5

[Jon Granrose]

QA to jj

Comment 6

[Simon Fraser [no longer active]]

1.0

Comment 7

[Simon Fraser [no longer active]]

Attachment: nsDsnService.h: include <Files.h> before <OpenTransport.h>

Comment 8

[Simon Fraser [no longer active]]

Attachment: All the patches in one file, with some changes

Changes from the above, individual patches:
1. Change to JavaScript.Prefix conditionalized on the compiler version.
2. Changes in macdll.c in NSPR to pass the fragment name to GetDiskFragment.

Comment 9

[Scott Collins]

Comment on attachment 76287 [details] [diff] [review]
All the patches in one file, with some changes

looks like some tab problems again ... but the code is all fine.  sr=scc

Comment 10

[Steve Dagley]

Comment on attachment 76287 [details] [diff] [review]
All the patches in one file, with some changes

r=sdagley (only ? is the whitesace in macdll.c)

Comment 11

[Wan-Teh Chang]

Comment on attachment 76287 [details] [diff] [review]
All the patches in one file, with some changes

I reviewed the NSPR changes.  They are fine.  r=wtc.

I asked Simon why he did not change one of the
GetDiskFragment calls in macdll.c and the GetDiskFragment
call in prlink.c.  I am satisfied with his explanation,
which I don't really understand.  (I just wanted to make
sure that he did not overlook those calls.)

Comment 12

[Simon Fraser [no longer active]]

Less scarey summary.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 76287 [details] [diff] [review]
All the patches in one file, with some changes

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 14

[Simon Fraser [no longer active]]

Fixes checked in. NSPR changes also committed to the NSPR tip.

Comment 15

[Patrick C. Beard]

Comment on attachment 76287 [details] [diff] [review]
All the patches in one file, with some changes

sr=beard