Allow building with CodeWarrior Pro 7.2

RESOLVED FIXED in mozilla1.0

Status

defect
RESOLVED FIXED
18 years ago
15 years ago

People

(Reporter: sfraser_bugs, Assigned: sfraser_bugs)

Tracking

Trunk
mozilla1.0
PowerPC
Mac System 9.x

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 5 obsolete attachments)

Bug for tracking build changes required to move to CodeWarrior Pro 7.2

Comment 5

18 years ago
QA to jj
QA Contact: granrose → jj
Assignee

Comment 6

18 years ago
1.0
Target Milestone: --- → mozilla1.0
Assignee

Comment 8

18 years ago
Changes from the above, individual patches:
1. Change to JavaScript.Prefix conditionalized on the compiler version.
2. Changes in macdll.c in NSPR to pass the fragment name to GetDiskFragment.
Attachment #76151 - Attachment is obsolete: true
Attachment #76152 - Attachment is obsolete: true
Attachment #76154 - Attachment is obsolete: true
Attachment #76155 - Attachment is obsolete: true
Attachment #76242 - Attachment is obsolete: true

Comment 9

18 years ago
Comment on attachment 76287 [details] [diff] [review]
All the patches in one file, with some changes

looks like some tab problems again ... but the code is all fine.  sr=scc
Attachment #76287 - Flags: superreview+

Comment 10

18 years ago
Comment on attachment 76287 [details] [diff] [review]
All the patches in one file, with some changes

r=sdagley (only ? is the whitesace in macdll.c)
Attachment #76287 - Flags: superreview+ → review+

Comment 11

18 years ago
Comment on attachment 76287 [details] [diff] [review]
All the patches in one file, with some changes

I reviewed the NSPR changes.  They are fine.  r=wtc.

I asked Simon why he did not change one of the
GetDiskFragment calls in macdll.c and the GetDiskFragment
call in prlink.c.  I am satisfied with his explanation,
which I don't really understand.  (I just wanted to make
sure that he did not overlook those calls.)
Assignee

Comment 12

18 years ago
Less scarey summary.
Summary: Update Mac build tools to Pro 7.2 → Allow building with CodeWarrior Pro 7.2
Comment on attachment 76287 [details] [diff] [review]
All the patches in one file, with some changes

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #76287 - Flags: approval+
Assignee

Comment 14

18 years ago
Fixes checked in. NSPR changes also committed to the NSPR tip.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

Comment 15

18 years ago
Comment on attachment 76287 [details] [diff] [review]
All the patches in one file, with some changes

sr=beard
Attachment #76287 - Flags: superreview+
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.