1334147 - autoland-ui: Fix <select>/<option> "selected" React Error

Status: RESOLVED FIXED

(Conduit :: General, defect)

Description

[David Walsh :davidwalsh]

React currently throwing the following error:

Warning: Use the `defaultValue` or `value` props on <select> instead of setting `selected` on <option>

Easy fix.

Comment 1

[David Walsh :davidwalsh]

Attachment: autoland-ui: Fix React warning from the fixture chooser (Bug 1334147).

Review commit: https://reviewboard.mozilla.org/r/107480/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107480/

Comment 2

[Israel Madueme [:imadueme]]

Comment on attachment 8830751 [details]
autoland-ui: Fix React warning from the fixture chooser (Bug 1334147).

https://reviewboard.mozilla.org/r/107480/#review108634

Whoops forgot to fix that myself. Thanks!

Comment 3

[Israel Madueme [:imadueme]]

Comment on attachment 8830751 [details]
autoland-ui: Fix React warning from the fixture chooser (Bug 1334147).

https://reviewboard.mozilla.org/r/107480/#review108640

::: autoland/ui/src/components/App.jsx:13
(Diff revision 1)
>    render() {
>      return (
>        <div>
>          <header>
>            <h1>Mozilla Autoland</h1>
>            <select onChange={this.changeDemoPage.bind(this)}>

Let's add `defaultValue=""` on the select here instead.

::: autoland/ui/src/components/App.jsx:14
(Diff revision 1)
>      return (
>        <div>
>          <header>
>            <h1>Mozilla Autoland</h1>
>            <select onChange={this.changeDemoPage.bind(this)}>
> -            <option value="" disabled selected>Change Demo Page</option>
> +            <option value="" disabled defaultValue>Change Demo Page</option>

Now that I actually test out the change, this doesn't work. Let's remove `defaultValue` from here.

Comment 4

[David Walsh :davidwalsh]

Comment on attachment 8830751 [details]
autoland-ui: Fix React warning from the fixture chooser (Bug 1334147).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107480/diff/1-2/

Comment 5

[David Walsh :davidwalsh]

Comment on attachment 8830751 [details]
autoland-ui: Fix React warning from the fixture chooser (Bug 1334147).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107480/diff/2-3/

Comment 6

[Israel Madueme [:imadueme]]

Comment on attachment 8830751 [details]
autoland-ui: Fix React warning from the fixture chooser (Bug 1334147).

https://reviewboard.mozilla.org/r/107480/#review108660

Noice!

Comment 7

[Steven MacLeod [:smacleod]]

Comment on attachment 8830751 [details]
autoland-ui: Fix React warning from the fixture chooser (Bug 1334147).

https://reviewboard.mozilla.org/r/107480/#review108958