Omit getComputedStyle's second argument when it's falsy

RESOLVED FIXED in Firefox 54

Status

()

Firefox
General
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: florian, Assigned: florian)

Tracking

53 Branch
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

7 months ago
Created attachment 8830820 [details]
xpcshell script

getComputedStyle's second parameter has been optional since bug 567350 / Gecko 2.0. Let's cleanup :-).
(Assignee)

Comment 1

7 months ago
Created attachment 8830823 [details] [diff] [review]
change to the no-useless-parameters rule + hand fixes

I fixed by hand a few occurences that my script missed:
- in xbl bindings, JS code outside of CDATA sections
- in devtools/client/inspector/markup/test because my exclusion path was a bit larger than needed (I think I only needed to exclude files with a lib_ prefix).
Attachment #8830823 - Flags: review?(jaws)
(Assignee)

Updated

7 months ago
Assignee: nobody → florian
Status: NEW → ASSIGNED
(Assignee)

Comment 2

7 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d18db679da4
(Assignee)

Comment 3

7 months ago
Created attachment 8830828 [details] [diff] [review]
script-generated patch
Attachment #8830828 - Flags: review?(jaws)
Attachment #8830823 - Flags: review?(jaws) → review+
Comment on attachment 8830828 [details] [diff] [review]
script-generated patch

Review of attachment 8830828 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8830828 - Flags: review?(jaws) → review+
(Assignee)

Comment 5

7 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/44495d8b46baf4d497ff927a7a804e77728ed09f
Bug 1334199 - make the no-useless-parameters eslint rule report getComputedStyle's second argument when it's falsy, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d02fd33024b876d9a5c7f4afa9bd103ed9d58e74
Bug 1334199 - script-generated patch to omit getComputedStyle's second argument when it's falsy, r=jaws.

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/44495d8b46ba
https://hg.mozilla.org/mozilla-central/rev/d02fd33024b8
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.