1334199 - Omit getComputedStyle's second argument when it's falsy

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Florian Quèze [:florian]]

Attachment: xpcshell script

getComputedStyle's second parameter has been optional since bug 567350 / Gecko 2.0. Let's cleanup :-).

Comment 1

[Florian Quèze [:florian]]

Attachment: change to the no-useless-parameters rule + hand fixes

I fixed by hand a few occurences that my script missed:
- in xbl bindings, JS code outside of CDATA sections
- in devtools/client/inspector/markup/test because my exclusion path was a bit larger than needed (I think I only needed to exclude files with a lib_ prefix).

Comment 2

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d18db679da4

Comment 3

[Florian Quèze [:florian]]

Attachment: script-generated patch

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8830828 [details] [diff] [review]
script-generated patch

Review of attachment 8830828 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44495d8b46baf4d497ff927a7a804e77728ed09f
Bug 1334199 - make the no-useless-parameters eslint rule report getComputedStyle's second argument when it's falsy, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d02fd33024b876d9a5c7f4afa9bd103ed9d58e74
Bug 1334199 - script-generated patch to omit getComputedStyle's second argument when it's falsy, r=jaws.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/44495d8b46ba
https://hg.mozilla.org/mozilla-central/rev/d02fd33024b8