1334214 - Port bug 1332245 package-manifest.in change to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Tooru Fujisawa [:arai]]

I'm about to add @RESPATH@/components/dom_bindings.xpt to package-manifest.in in bug 1332245.

package-manifest.in files in comm-central also needs same change.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Add dom_bindings.xpt to package-manifest.in and removed-files.in.

added dom_bindings.xpt to following files:
  im/installer/package-manifest.in
  mail/installer/package-manifest.in
  suite/installer/package-manifest.in

not sure if it's necessary tho also aded to following files, where dom_base.xpt is also listed:
  im/installer/removed-files.in
  mail/installer/removed-files.in
  suite/installer/removed-files.in

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 8830847 [details] [diff] [review]
Add dom_bindings.xpt to package-manifest.in and removed-files.in.

Joshua isn't so fast in reviews. Adding other reviewers.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8830847 [details] [diff] [review]
Add dom_bindings.xpt to package-manifest.in and removed-files.in.

Review of attachment 8830847 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. These days we land changes to package-manifest.in with one or no review at all. We change those files about once to twice a day to keep up with M-C, let's see: Today and yesterday: Two changesets hitting those files.

As for removed-files.in, I think there is agreement that we don't update this any more, see bug 1330757 comment #3 and bug 1330757 comment #7. But let's clarify this again.

Aleth, Ratty, what do we do with removed-files.in?

Anyway, Tooru, thanks for the heads-up, Richard and myself will be watching your bug to land this with or without the changes to removed-files.in.

Comment 4

[Jorg K (CEST = GMT+2)]

To update or not to update removed-files.in, this is the question ;-)

Comment 5

[Jorg K (CEST = GMT+2)]

(In reply to Jorg K (GMT+1) from comment #3)
> We change those files about once to twice a day ...
https://hg.mozilla.org/comm-central/log/tip/mail/installer/package-manifest.in

Some reading here:
https://dxr.mozilla.org/comm-central/rev/1994d82f97322ab5fc42601ad49a859a6844e96b/im/installer/removed-files.in#5

These files are not regularly updated:
https://hg.mozilla.org/comm-central/log/tip/suite/installer/removed-files.in
https://hg.mozilla.org/comm-central/log/tip/mail/installer/removed-files.in
https://hg.mozilla.org/comm-central/log/tip/im/installer/removed-files.in

And nothing got added in bug 1330757:
https://hg.mozilla.org/comm-central/rev/d4fb23de45465e419feb385b79d1e201dcc82759

or bug 1318737:
https://hg.mozilla.org/comm-central/rev/80e1fa44bed8

or bug 1301885:
https://hg.mozilla.org/comm-central/rev/9252289a33d6

Comment 6

[aleth [:aleth]]

I don't think adding it to removed-files.in is required, these days that mainly applies to directories.

As jorgk points out, the c-c removed-files.in are a bit out of date and could be cleaned up a bit.

Comment 7

[aleth [:aleth]]

Ah, I see the confusion in this bug arose from the existing reference to dom_*.xpt in removed-files.in. This is in a really old section of removed-files.in that refers to a file move many years ago. Note the preceding comment http://searchfox.org/comm-central/source/mail/installer/removed-files.in#1032

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: Add dom_bindings.xpt to package-manifest.in

Patch ready to land with the hunks in removed-files.in removed.

Comment 9

[Tooru Fujisawa [:arai]]

thanks, I'll land bug 1332245 patch.

Comment 10

[Philip Chee]

Actually most of removed-files.in can be removed. And adding anything new to that file is pretty much useless. removed-files.in pre-dates omni.jar/onmi.ja

Comment 11

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/fdc6a3e536479536fffdfd057d41e65aa191d871