Closed Bug 1334228 Opened 3 years ago Closed 3 years ago

Add separate asserts for not being opened in AssertWorkerThread and AssertLinkThread

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file, 1 obsolete file)

These methods have a release assert that checks that the worker loop ID for the channel matches the current one. It would be nice if in debug builds we have a separate assertion if mWorkerLoopID is -1, because that really means that the channel just hasn't been opened yet, instead of that it is being used on the wrong thread. I'll make this debug only, as there's no need to make the release asserts fancier.
Summary: Add separate asserts for not being initalized in AssertWorkerThread and AssertLinkThread → Add separate asserts for not being opened in AssertWorkerThread and AssertLinkThread
MozReview-Commit-ID: KqNdMEPieCk
Attachment #8830858 - Attachment is obsolete: true
Comment on attachment 8830982 [details]
Bug 1334228 - Add separate assertions for message channels that haven't been opened.

https://reviewboard.mozilla.org/r/107636/#review110218
Attachment #8830982 - Flags: review?(kchen) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6905cedb8cad
Add separate assertions for message channels that haven't been opened. r=kanru
https://hg.mozilla.org/mozilla-central/rev/6905cedb8cad
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.