1334228 - Add separate asserts for not being opened in AssertWorkerThread and AssertLinkThread

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

These methods have a release assert that checks that the worker loop ID for the channel matches the current one. It would be nice if in debug builds we have a separate assertion if mWorkerLoopID is -1, because that really means that the channel just hasn't been opened yet, instead of that it is being used on the wrong thread. I'll make this debug only, as there's no need to make the release asserts fancier.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Add separate assertions for message channels that haven't been opened.

MozReview-Commit-ID: KqNdMEPieCk

Comment 2

[Andrew McCreight [:mccr8]]

try looks okay: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c159bfb391d5924523462a0699f928511d9aa2e

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1334228 - Add separate assertions for message channels that haven't been opened.

Review commit: https://reviewboard.mozilla.org/r/107636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107636/

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8830982 [details]
Bug 1334228 - Add separate assertions for message channels that haven't been opened.

https://reviewboard.mozilla.org/r/107636/#review110218

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6905cedb8cad
Add separate assertions for message channels that haven't been opened. r=kanru

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6905cedb8cad