1334242 - add BUG_COMPONENT to dom/security/* files

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

for finding ownership of files (source/tests), it helps to map source files to bugzilla components.  

I see:
dom/security/
 - *.cpp/*.h
 - contentverifier/
 - cors/
 - csp/
 - general/
 - gtest/
 - hsts/
 - mixedcontentblocker/
 - sri/
 - unit/


as far as I can tell, all of these files belong in:
Core::DOM: Security

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to dom/security/*

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to dom/security/*

oops, accidentally had a few extra changes in this patch, uploading the right set of changes this time.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8830879 [details] [diff] [review]
add BUG_COMPONENT to dom/security/*

Review of attachment 8830879 [details] [diff] [review]:
-----------------------------------------------------------------

I think that is fine even though nsCORSListenerProxy is now part of /netwerk/ again, which means that dom/security/test/cors is also rather part of Networking thatn DOM:Security. But as I said, I suppose that's fine.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to dom/security/*

carry over r+ (will land tomorrow), this is how file-info shows the bugzilla components:

$ ./mach file-info bugzilla-component dom/security/**
Core :: DOM: Security
  dom/security/ContentVerifier.cpp
  dom/security/ContentVerifier.h
  dom/security/SRICheck.cpp
  dom/security/SRICheck.h
  dom/security/SRILogHelper.h
  dom/security/SRIMetadata.cpp
  dom/security/SRIMetadata.h
  dom/security/moz.build
  dom/security/nsCSPContext.cpp
  dom/security/nsCSPContext.h
  dom/security/nsCSPParser.cpp
  dom/security/nsCSPParser.h
  dom/security/nsCSPService.cpp
  dom/security/nsCSPService.h
  dom/security/nsCSPUtils.cpp
  dom/security/nsCSPUtils.h
  dom/security/nsContentSecurityManager.cpp
  dom/security/nsContentSecurityManager.h
  dom/security/nsMixedContentBlocker.cpp
  dom/security/nsMixedContentBlocker.h
  dom/security/test

elvis@JMAHER-WIN10 ~/mozilla-inbound
$ ./mach file-info bugzilla-component dom/security/test/**
Core :: DOM: Security
  dom/security/test/contentverifier
  dom/security/test/csp
  dom/security/test/general
  dom/security/test/gtest
  dom/security/test/hsts
  dom/security/test/mixedcontentblocker
  dom/security/test/moz.build
  dom/security/test/sri
  dom/security/test/unit
Core :: Networking
  dom/security/test/cors


thanks for the tip on cors!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f5409db1252
add BUG_COMPONENT to dom/security/* files. r=ckerschb

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2f5409db1252