1334250 - Avoid more removeEventListener calls when {once: true} can be used instead

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Florian Quèze [:florian]]

Attachment: xpcshell script

The script used in bug 1331599 missed cases where the event listener was added and removed using a variable for the event name.

Comment 1

[Florian Quèze [:florian]]

Attachment: changes made by hand

This includes tweaks to the eslint rule, and changes that couldn't be handled by the script due to the capture value being in a variable.

Comment 2

[Florian Quèze [:florian]]

Attachment: script-generated patch

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8830893 [details] [diff] [review]
script-generated patch

Review of attachment 8830893 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the below code removed and the function name removed as well since it is no longer necessary.

::: b2g/components/ContentRequestHelper.jsm
@@ +39,5 @@
>        if (!msg || !msg.id || msg.id != id) {
>          deferred.reject("InternalErrorWrongContentEvent " +
>                          JSON.stringify(msg));
>          SystemAppProxy.removeEventListener(aContentEventName,
>                                             onContentEvent);

This is duplicate/unnecessary code?

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b838ee5b00577a898bf66a3958736e0727c8b796
Bug 1334250 - adapt the no-useless-removeEventListener rule to handle the listener being added and removed with the same variable + some hand fixes, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/87fde7e63c1a0a7d808e2f178191f3187057c4e7
Bug 1334250 - script-generated patch to avoid removeEventListener calls when a variable is used for the event name, r=jaws.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b838ee5b0057
https://hg.mozilla.org/mozilla-central/rev/87fde7e63c1a