Closed
Bug 1334268
Opened 7 years ago
Closed 7 years ago
js/src/old-configure reports "grep: invalid option" on Windows
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.95 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
When building jsshell on Windows using mozilla-build 32-bit environment, the configure process has the following error message:
<<<
checking for _getc_nolock... (cached) yes
checking for sb-conf... no
checking for ve... no
checking for X... (cached) no
grep: invalid option -- /
Usage: grep [OPTION]... PATTERN [FILE]...
Try `grep --help' for more information.
grep: invalid option -- /
Usage: grep [OPTION]... PATTERN [FILE]...
Try `grep --help' for more information.
checking for valid debug flags... yes
checking NSPR selection... source-tree
checking what kind of list files are supported by the linker... list
>>>
This is caused by autoconf quoting problems, and a fix is attached.
Even with the error, the result for a default config is the same. Problems might have occurred if manually specifying -arch flag.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → tcampbell
Attachment #8830920 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4eac9137919d544b14000f5b563afe833eb39a6 Try in progress
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8830920 [details] [diff] [review] 0001-Bug-1334268-Fix-regex-escaping-in-js-src-old-configu.patch Review of attachment 8830920 [details] [diff] [review]: ----------------------------------------------------------------- The same change is needed in top-level old-configure.in.
Attachment #8830920 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Comment 4•7 years ago
|
||
Attachment #8830920 -
Attachment is obsolete: true
Attachment #8833174 -
Flags: review?(mh+mozilla)
|
|
||
Updated•7 years ago
|
Attachment #8833174 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/00f1ed73cf65 Fix regex escaping in js/src/old-configure. r=glandium
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/00f1ed73cf65
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•