1334283 - use MOZ_FORMAT_PRINTF in updatelogging.h

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Tom Tromey :tromey]

Auditing printf-likes during bug 1060419 revealed that two methods in
UpdateLog (in toolkit/mozapps/update/common/updatelogging.h) could use
MOZ_FORMAT_PRINTF.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1334283 - use MOZ_FORMAT_PRINTF in toolkit/mozapps/update;

Use MOZ_FORMAT_PRINTF in toolkit/mozapps/update, and fix the one
erroneous printf that this detected.

Review commit: https://reviewboard.mozilla.org/r/135602/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135602/

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 8863858 [details]
Bug 1334283 - use MOZ_FORMAT_PRINTF in toolkit/mozapps/update;

https://reviewboard.mozilla.org/r/135602/#review138686

I pushed this atch to oak since I'm testing some patches there and it failed to compile on Linux TC (possibly others)

[task 2017-05-02T22:57:32.944053Z] 22:57:32     INFO -  In file included from /home/worker/workspace/build/src/toolkit/mozapps/update/common/updatecommon.cpp:15:
[task 2017-05-02T22:57:32.944332Z] 22:57:32     INFO -  /home/worker/workspace/build/src/toolkit/mozapps/update/common/updatecommon.h:23:37: error: expected ';' at end of declaration list
[task 2017-05-02T22:57:32.944588Z] 22:57:32     INFO -    void Printf(const char *fmt, ... ) MOZ_FORMAT_PRINTF(2, 3);
[task 2017-05-02T22:57:32.944905Z] 22:57:32     INFO -                                      ^
[task 2017-05-02T22:57:32.945170Z] 22:57:32     INFO -                                      ;
[task 2017-05-02T22:57:32.945435Z] 22:57:32     INFO -  /home/worker/workspace/build/src/toolkit/mozapps/update/common/updatecommon.h:24:41: error: expected ';' at end of declaration list
[task 2017-05-02T22:57:32.945694Z] 22:57:32     INFO -    void WarnPrintf(const char *fmt, ... ) MOZ_FORMAT_PRINTF(2, 3);
[task 2017-05-02T22:57:32.945889Z] 22:57:32     INFO -                                          ^
[task 2017-05-02T22:57:32.946248Z] 22:57:32     INFO -                                          ;
[task 2017-05-02T22:57:32.947829Z] 22:57:32     INFO -  2 errors generated.
[task 2017-05-02T22:57:32.947926Z] 22:57:32     INFO -  /home/worker/workspace/build/src/config/rules.mk:1059: recipe for target 'updatecommon.o' failed
[task 2017-05-02T22:57:32.947972Z] 22:57:32     INFO -  gmake[5]: *** [updatecommon.o] Error 1
[task 2017-05-02T22:57:32.948035Z] 22:57:32     INFO -  gmake[5]: Leaving directory '/home/worker/workspace/build/src/obj-firefox/toolkit/mozapps/update/common'
[task 2017-05-02T22:57:32.949000Z] 22:57:32     INFO -  /home/worker/workspace/build/src/config/recurse.mk:73: recipe for target 'toolkit/mozapps/update/common/target' failed
[task 2017-05-02T22:57:32.949062Z] 22:57:32     INFO -  gmake[4]: *** [toolkit/mozapps/update/common/target] Error 2
[task 2017-05-02T22:57:32.949107Z] 22:57:32     INFO -  gmake[4]: *** Waiting for unfinished jobs....

Comment 3

[Robert Strong (they/them - no direct email)]

Definitely others
https://treeherder.mozilla.org/#/jobs?repo=oak&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&tochange=2ce6356d52a337f1a1152978eab5249e573ee226&fromchange=2ce6356d52a337f1a1152978eab5249e573ee226

Comment 4

[Tom Tromey :tromey]

Sorry about that, I'll fix.  It built fine here.
FWIW in devtools we normally push to try after review.
However I can do it the other way.

Comment 5

[Tom Tromey :tromey]

Just the usual unified build thing, where it works for some builds but not others.
Adding a #include fixed it up.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b17c6aed8ebd8df4c0c69d44d7faf328a2869300

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8863858 [details]
Bug 1334283 - use MOZ_FORMAT_PRINTF in toolkit/mozapps/update;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135602/diff/1-2/

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 8863858 [details]
Bug 1334283 - use MOZ_FORMAT_PRINTF in toolkit/mozapps/update;

https://reviewboard.mozilla.org/r/135602/#review138970

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dde97182bda
use MOZ_FORMAT_PRINTF in toolkit/mozapps/update; r=rstrong

Comment 9

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/0dde97182bda