1334286 - use MOZ_FORMAT_PRINTF in DMD

Status: RESOLVED FIXED

(Core :: DMD, defect)

Description

[Tom Tromey :tromey]

Auditing printf-likes in bug 1060419 revealed that DMD could use
MOZ_FORMAT_PRINTF in a few spots, namely the various implementations
of StatusMsg.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1334286 - use MOZ_FORMAT_PRINTF in DMD;

Add MOZ_FORMAT_PRINTF to the appropriate spots in DMD and fix up the
one (trivial) error that this pointed out.

Review commit: https://reviewboard.mozilla.org/r/134006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134006/

Comment 2

[Tom Tromey :tromey]

IIUC to run this in try I have to also add a patch to update some moz config files.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8862053 [details]
Bug 1334286 - use MOZ_FORMAT_PRINTF in DMD;

https://reviewboard.mozilla.org/r/134006/#review137014

::: memory/replace/dmd/DMD.h:53
(Diff revision 1)
>  
>    virtual void Analyze(UniquePtr<JSONWriteFunc>);
>  
>    virtual void SizeOf(Sizes*);
>  
> -  virtual void StatusMsg(const char*, va_list);
> +  virtual void StatusMsg(const char*, va_list) MOZ_FORMAT_PRINTF(2, 0);

Is 0 the second arg here because it takes a va_list instead of ...? The docs in mfbt/Attributes.h don't mention that case.

Comment 4

[Nicholas Nethercote [inactive]]

(In reply to Tom Tromey :tromey from comment #2)
> IIUC to run this in try I have to also add a patch to update some moz config
> files.

You're in luck. DMD is enabled for debug builds on TreeHerder -- there is even an xpcshelltest -- so you won't have to do that.

Comment 5

[Tom Tromey :tromey]

(In reply to Nicholas Nethercote [:njn] from comment #3)

> > +  virtual void StatusMsg(const char*, va_list) MOZ_FORMAT_PRINTF(2, 0);
> 
> Is 0 the second arg here because it takes a va_list instead of ...?

Yes.  See also bug 1334279.
This is part of GCC's definition of the attribute.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c090ad2183e
use MOZ_FORMAT_PRINTF in DMD; r=njn

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9c090ad2183e