Closed Bug 1334302 Opened 3 years ago Closed 3 years ago

nsCSSRenderingBorders.h:PrintAsFormatString could use MOZ_FORMAT_PRINTF

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Auditing printf-likes in bug 1060419 revealed that nsCSSRenderingBorders.h:PrintAsFormatString
could use MOZ_FORMAT_PRINTF.
I haven't tried but it seems best to me to annotate both implementations
of the function, to get checking even when the function is defined as a no-op.
Component: Graphics: Layers → Layout
Whiteboard: [gfx-noted]
Assignee: nobody → ttromey
Comment on attachment 8862159 [details]
Bug 1334302 - use MOZ_FORMAT_PRINTF in nsCSSRenderingBorders.h;

https://reviewboard.mozilla.org/r/134138/#review137076
Attachment #8862159 - Flags: review?(matt.woodrow) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c9232d39a06
use MOZ_FORMAT_PRINTF in nsCSSRenderingBorders.h; r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/0c9232d39a06
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.