1334302 - nsCSSRenderingBorders.h:PrintAsFormatString could use MOZ_FORMAT_PRINTF

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Tom Tromey :tromey]

Auditing printf-likes in bug 1060419 revealed that nsCSSRenderingBorders.h:PrintAsFormatString
could use MOZ_FORMAT_PRINTF.
I haven't tried but it seems best to me to annotate both implementations
of the function, to get checking even when the function is defined as a no-op.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1334302 - use MOZ_FORMAT_PRINTF in nsCSSRenderingBorders.h;

Add MOZ_FORMAT_PRINTF to the definitions of PrintAsFormatString in
nsCSSRenderingBorders.h.

Review commit: https://reviewboard.mozilla.org/r/134138/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134138/

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8862159 [details]
Bug 1334302 - use MOZ_FORMAT_PRINTF in nsCSSRenderingBorders.h;

https://reviewboard.mozilla.org/r/134138/#review137076

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c9232d39a06
use MOZ_FORMAT_PRINTF in nsCSSRenderingBorders.h; r=mattwoodrow

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0c9232d39a06