Closed
Bug 1334426
Opened 7 years ago
Closed 7 years ago
Followup bug on tracelogger cleanups
Categories
(Core :: JavaScript Engine: JIT, defect, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: h4writer, Assigned: h4writer)
References
Details
Attachments
(1 file)
|
7.72 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
Spin-off from review on bug 1334129. Make sure --disable-tracelogging works again and use UniquePtr more often.
|
Assignee | |
Updated•7 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → hv1989
Attachment #8831083 -
Flags: review?(bbouvier)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8831083 [details] [diff] [review] Part 1: Get --disable-trace-logging working again. Review of attachment 8831083 [details] [diff] [review]: ----------------------------------------------------------------- Thanks ::: js/src/jit/shared/CodeGenerator-shared.h @@ +585,2 @@ > emitTracelogTree(/* isStart =*/ false, text, enabledTextId); > +#endif I'd think it'd look better if there was a big block #ifdef JS_TRACE_LOGGING all the function defs #else all the empty function defs #endif
Attachment #8831083 -
Flags: review?(bbouvier) → review+
Pushed by hv1989@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dc074025662d TraceLogger: Silently fail the logger when not-recoverable, r=bbouvier
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dc074025662d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
|
Assignee | |
Comment 6•7 years ago
|
||
I used wrong bugnumbers. This landed as: https://hg.mozilla.org/mozilla-central/rev/740e1005d4b6
You need to log in
before you can comment on or make changes to this bug.
Description
•