run mochitest-gpu tests on ubuntu 16.04 instead of 12.04

RESOLVED FIXED in Firefox 54

Status

()

Core
Canvas: 2D
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

unspecified
mozilla54
Unspecified
Linux
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 months ago
currently we have 1 test which has a leak on linux64-asan when run on ubuntu 16.04, this test is dom/canvas/test/crossorigin/test_video_crossorigin.html.

the leak[0] has this signature:
[task 2017-01-23T12:29:19.757321Z] 12:29:19     INFO - ==1336==ERROR: LeakSanitizer: detected memory leaks
[task 2017-01-23T12:29:19.757929Z] 12:29:19     INFO - Direct leak of 40 byte(s) in 1 object(s) allocated from:
[task 2017-01-23T12:29:19.758062Z] 12:29:19     INFO -     #0 0x4b26f4 in calloc /builds/slave/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:66:3
[task 2017-01-23T12:29:19.758677Z] 12:29:19     INFO -     #1 0x7f428553e9ae in pa_xmalloc0 (/usr/lib/x86_64-linux-gnu/pulseaudio/libpulsecommon-8.0.so+0x149ae)
[task 2017-01-23T12:29:19.758804Z] 12:29:19     INFO -     #2 0x7f429c1489aa in pulse_init /home/worker/workspace/build/src/media/libcubeb/src/cubeb_pulse.c:652:7
[task 2017-01-23T12:29:19.759617Z] 12:29:19     INFO -     #3 0x7f429c146b6e in cubeb_init /home/worker/workspace/build/src/media/libcubeb/src/cubeb.c:149:9
[task 2017-01-23T12:29:19.760275Z] 12:29:19     INFO -     #4 0x7f42982ad25b in mozilla::CubebUtils::GetCubebContextUnlocked() /home/worker/workspace/build/src/dom/media/CubebUtils.cpp:244:12
[task 2017-01-23T12:29:19.760369Z] 12:29:19     INFO -     #5 0x7f42982ad389 in mozilla::CubebUtils::InitPreferredSampleRate() /home/worker/workspace/build/src/dom/media/CubebUtils.cpp:180:20
[task 2017-01-23T12:29:19.764568Z] 12:29:19     INFO -     #6 0x7f42982ad3ff in mozilla::CubebUtils::PreferredSampleRate() /home/worker/workspace/build/src/dom/media/CubebUtils.cpp:195:8
[task 2017-01-23T12:29:19.766222Z] 12:29:19     INFO -     #7 0x7f42984751b1 in mozilla::MediaStreamGraph::GetInstance(mozilla::MediaStreamGraph::GraphDriverType, mozilla::dom::AudioChannel) /home/worker/workspace/build/src/dom/media/MediaStreamGraph.cpp:3446:38
[task 2017-01-23T12:29:19.768062Z] 12:29:19     INFO -     #8 0x7f42982ac42d in mozilla::dom::CanvasCaptureMediaStream::CreateSourceStream(nsPIDOMWindowInner*, mozilla::dom::HTMLCanvasElement*) /home/worker/workspace/build/src/dom/media/CanvasCaptureMediaStream.cpp:276:5
[task 2017-01-23T12:29:19.769786Z] 12:29:19     INFO -     #9 0x7f4298008742 in mozilla::dom::HTMLCanvasElement::CaptureStream(mozilla::dom::Optional<double> const&, mozilla::ErrorResult&) /home/worker/workspace/build/src/dom/html/HTMLCanvasElement.cpp:736:5
[task 2017-01-23T12:29:19.776193Z] 12:29:19     INFO -     #10 0x7f4297682119 in mozilla::dom::HTMLCanvasElementBinding::captureStream(JSContext*, JS::Handle<JSObject*>, mozilla::dom::HTMLCanvasElement*, JSJitMethodCallArgs const&) /home/worker/workspace/build/src/obj-firefox/dom/bindings/HTMLCanvasElementBinding.cpp:635:70
[task 2017-01-23T12:29:19.778509Z] 12:29:19     INFO -     #11 0x7f4297990150 in mozilla::dom::GenericBindingMethod(JSContext*, unsigned int, JS::Value*) /home/worker/workspace/build/src/dom/bindings/BindingUtils.cpp:2914:13
[task 2017-01-23T12:29:19.780653Z] 12:29:19     INFO -     #12 0x7f429d3cca4c in CallJSNative /home/worker/workspace/build/src/js/src/jscntxtinlines.h:239:15
[task 2017-01-23T12:29:19.781964Z] 12:29:19     INFO -     #13 0x7f429d3cca4c in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:460
[task 2017-01-23T12:29:19.783102Z] 12:29:19     INFO -     #14 0x7f429d3b27de in CallFromStack /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:511:12
[task 2017-01-23T12:29:19.784794Z] 12:29:19     INFO -     #15 0x7f429d3b27de in Interpret(JSContext*, js::RunState&) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:2956
[task 2017-01-23T12:29:19.786530Z] 12:29:19     INFO -     #16 0x7f429d3966d1 in js::RunScript(JSContext*, js::RunState&) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:406:12
[task 2017-01-23T12:29:19.788634Z] 12:29:19     INFO -     #17 0x7f429d3ccccc in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:478:15
[task 2017-01-23T12:29:19.793850Z] 12:29:19     INFO -     #18 0x7f429d3cd382 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) /home/worker/workspace/build/src/js/src/vm/Interpreter.cpp:524:10
[task 2017-01-23T12:29:19.795184Z] 12:29:19     INFO -     #19 0x7f429dc277ad in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /home/worker/workspace/build/src/js/src/jsapi.cpp:2847:12
[task 2017-01-23T12:29:19.798240Z] 12:29:19     INFO -     #20 0x7f42974f149c in mozilla::dom::EventListener::HandleEvent(JSContext*, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) /home/worker/workspace/build/src/obj-firefox/dom/bindings/EventListenerBinding.cpp:47:8
[task 2017-01-23T12:29:19.802137Z] 12:29:19     INFO -     #21 0x7f4297ddc682 in HandleEvent<mozilla::dom::EventTarget *> /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/EventListenerBinding.h:64:12
[task 2017-01-23T12:29:19.804367Z] 12:29:19     INFO -     #22 0x7f4297ddc682 in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, nsIDOMEvent*, mozilla::dom::EventTarget*) /home/worker/workspace/build/src/dom/events/EventListenerManager.cpp:1132
[task 2017-01-23T12:29:19.824069Z] 12:29:19     INFO -     #23 0x7f4297dde24c in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, nsIDOMEvent**, mozilla::dom::EventTarget*, nsEventStatus*) /home/worker/workspace/build/src/dom/events/EventListenerManager.cpp:1318:20
[task 2017-01-23T12:29:19.827834Z] 12:29:19     INFO -     #24 0x7f4297dc9013 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /home/worker/workspace/build/src/dom/events/EventDispatcher.cpp:462:5
[task 2017-01-23T12:29:19.830656Z] 12:29:19     INFO -     #25 0x7f4297dcc904 in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, nsIDOMEvent*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /home/worker/workspace/build/src/dom/events/EventDispatcher.cpp:819:9
[task 2017-01-23T12:29:19.836224Z] 12:29:19     INFO -     #26 0x7f4297dcec07 in mozilla::EventDispatcher::DispatchDOMEvent(nsISupports*, mozilla::WidgetEvent*, nsIDOMEvent*, nsPresContext*, nsEventStatus*) /home/worker/workspace/build/src/dom/events/EventDispatcher.cpp:888:12
[task 2017-01-23T12:29:19.838574Z] 12:29:19     INFO -     #27 0x7f4296037bd1 in nsINode::DispatchEvent(nsIDOMEvent*, bool*) /home/worker/workspace/build/src/dom/base/nsINode.cpp:1322:5
[task 2017-01-23T12:29:19.840926Z] 12:29:19     INFO -     #28 0x7f4295b69707 in nsContentUtils::DispatchEvent(nsIDocument*, nsISupports*, nsAString_internal const&, bool, bool, bool, bool*, bool) /home/worker/workspace/build/src/dom/base/nsContentUtils.cpp:4041:10
[task 2017-01-23T12:29:19.845913Z] 12:29:19     INFO -     #29 0x7f4295b694d5 in nsContentUtils::DispatchTrustedEvent(nsIDocument*, nsISupports*, nsAString_internal const&, bool, bool, bool*) /home/worker/workspace/build/src/dom/base/nsContentUtils.cpp:4009:10
[task 2017-01-23T12:29:19.848614Z] 12:29:19     INFO -     #30 0x7f42981184b5 in mozilla::dom::HTMLMediaElement::DispatchEvent(nsAString_internal const&) /home/worker/workspace/build/src/dom/html/HTMLMediaElement.cpp:5891:10
[task 2017-01-23T12:29:19.850782Z] 12:29:19     INFO -     #31 0x7f429354e03b in nsThread::ProcessNextEvent(bool, bool*) /home/worker/workspace/build/src/xpcom/threads/nsThread.cpp:1240:7
[task 2017-01-23T12:29:19.854613Z] 12:29:19     INFO -     #32 0x7f42935d08fc in NS_ProcessNextEvent(nsIThread*, bool) /home/worker/workspace/build/src/xpcom/glue/nsThreadUtils.cpp:390:10
[task 2017-01-23T12:29:19.856155Z] 12:29:19     INFO - -----------------------------------------------------
[task 2017-01-23T12:29:19.857771Z] 12:29:19     INFO - Suppressions used:
[task 2017-01-23T12:29:19.861278Z] 12:29:19     INFO -   count      bytes template
[task 2017-01-23T12:29:19.863164Z] 12:29:19     INFO -     257       3689 libc.so
[task 2017-01-23T12:29:19.864844Z] 12:29:19     INFO -     783      25000 nsComponentManagerImpl
[task 2017-01-23T12:29:19.866718Z] 12:29:19     INFO -       7       1008 mozJSComponentLoader::LoadModule
[task 2017-01-23T12:29:19.869903Z] 12:29:19     INFO -     354      14016 libfontconfig.so
[task 2017-01-23T12:29:19.872244Z] 12:29:19     INFO -      16       2316 libglib-2.0.so
[task 2017-01-23T12:29:19.873919Z] 12:29:19     INFO -       1         88 libpulse.so
[task 2017-01-23T12:29:19.876792Z] 12:29:19     INFO - -----------------------------------------------------
[task 2017-01-23T12:29:19.878585Z] 12:29:19     INFO - SUMMARY: AddressSanitizer: 40 byte(s) leaked in 1 allocation(s).
[task 2017-01-23T12:29:21.700674Z] 12:29:21     INFO - -----------------------------------------------------
[task 2017-01-23T12:29:21.706352Z] 12:29:21     INFO - Suppressions used:
[task 2017-01-23T12:29:21.706407Z] 12:29:21     INFO -   count      bytes template
[task 2017-01-23T12:29:21.706445Z] 12:29:21     INFO -     257       3493 libc.so
[task 2017-01-23T12:29:21.706487Z] 12:29:21     INFO -     800      25512 nsComponentManagerImpl
[task 2017-01-23T12:29:21.706532Z] 12:29:21     INFO -      46       6624 mozJSComponentLoader::LoadModule
[task 2017-01-23T12:29:21.706579Z] 12:29:21     INFO -       1        384 pixman_implementation_lookup_composite
[task 2017-01-23T12:29:21.706619Z] 12:29:21     INFO -     354      14016 libfontconfig.so
[task 2017-01-23T12:29:21.706655Z] 12:29:21     INFO -       1         32 libdl.so
[task 2017-01-23T12:29:21.706904Z] 12:29:21     INFO -      17       4348 libglib-2.0.so
[task 2017-01-23T12:29:21.707299Z] 12:29:21     INFO -       1         28 libresolv.so
[task 2017-01-23T12:29:21.707769Z] 12:29:21     INFO - -----------------------------------------------------
[task 2017-01-23T12:29:21.916080Z] 12:29:21     INFO - TEST-INFO | Main app process: exit 0
[task 2017-01-23T12:29:21.916961Z] 12:29:21     INFO - TEST-INFO | LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2017-01-23T12:29:21.918381Z] 12:29:21     INFO - TEST-INFO | LeakSanitizer | This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2017-01-23T12:29:21.919470Z] 12:29:21    ERROR - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at pa_xmalloc0, pulse_init, cubeb_init, mozilla::CubebUtils::GetCubebContextUnlocked


I suspect this will be fixed by bug 1332902.

[0] https://public-artifacts.taskcluster.net/dXtNZTjyRXaFp_NnWiCFzw/0/public/logs/live_backing.log
(Assignee)

Comment 1

9 months ago
Created attachment 8831119 [details] [diff] [review]
run mochitest-gpu on 16.04 (and disable one test on asan)

adding patch here for posterity- if we fix the leak, we can simplify this patch :)

Updated

9 months ago
OS: Unspecified → Linux
Priority: -- → P3
Whiteboard: [gfx-noted]
(Assignee)

Comment 2

9 months ago
Created attachment 8832641 [details] [diff] [review]
run mochitest-gpu on 16.04

the leak has *disappeared*, so just a simple docker image change :)
Assignee: nobody → jmaher
Attachment #8831119 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8832641 - Flags: review?(milan)
(Assignee)

Comment 3

9 months ago
oh, and the try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1418f0d43dd5a7f0f0aff30faaa1b5870801580&filter-searchStr=gpu
Attachment #8832641 - Flags: review?(milan) → review+

Comment 4

9 months ago
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bfef85f7ae5
run mochitest-gpu tests on ubuntu 16.04 instead of 12.04. r=milan

Comment 5

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4bfef85f7ae5
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.